Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SENTRY_DSN -> SENTRY_LARAVEL_DSN #130

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Update SENTRY_DSN -> SENTRY_LARAVEL_DSN #130

merged 1 commit into from
Apr 30, 2018

Conversation

stayallive
Copy link
Collaborator

This should fix the problems from #105.

@stayallive stayallive mentioned this pull request Apr 26, 2018
Closed
@m1guelpf
Copy link

@stayallive Isn't this a breaking change?

@stayallive
Copy link
Collaborator Author

No. Since right now SENTRY_DSN in the .env always takes precedence whatever you do in the laravel config (see #105).

So as long as you have the dsn set the old way that will apply untill you switch over if you need to. It is currently “broken” bit this change wont do anything for existing installations.

@stayallive
Copy link
Collaborator Author

Also this is being release as 0.9 probably and this allows for breakong changes anyhow :) Will be documented in the changelog too.

@stayallive stayallive merged commit d6eaa73 into master Apr 30, 2018
@stayallive stayallive deleted the update-env-var-name branch April 30, 2018 11:47
@morrislaptop morrislaptop mentioned this pull request Apr 3, 2019
Merged
stayallive added a commit that referenced this pull request Apr 23, 2019
@morrislaptop @HazAT @stayallive
Fallback to SENTRY_DSN if defined in env (#224)
a89a3d5 
* Fallback to SENTRY_DSN if defined in env

#136 #105 #130

* Fix broken config syntax


Co-authored-by: Daniel Griesser <daniel.griesser.86@gmail.com>
Co-authored-by: Alex Bouma <me@alexbouma.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stayallive @m1guelpf