From a083163d15e8bccd20eda4429a941d3360506154 Mon Sep 17 00:00:00 2001 From: Markus Hintersteiner Date: Wed, 22 May 2024 09:27:40 +0200 Subject: [PATCH] Address PR feedback --- ndk/build.gradle.kts | 2 -- ndk/detekt.yml | 3 --- ndk/lib/build.gradle.kts | 9 +-------- 3 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 ndk/detekt.yml diff --git a/ndk/build.gradle.kts b/ndk/build.gradle.kts index 5100f2ff8..4e9ded034 100644 --- a/ndk/build.gradle.kts +++ b/ndk/build.gradle.kts @@ -140,12 +140,10 @@ spotless { kotlin { target("**/*.kt") ktlint() - targetExclude("**/sentry-native/**") } kotlinGradle { target("**/*.kts") ktlint() - targetExclude("**/sentry-native/**") } } diff --git a/ndk/detekt.yml b/ndk/detekt.yml deleted file mode 100644 index 49f91ae64..000000000 --- a/ndk/detekt.yml +++ /dev/null @@ -1,3 +0,0 @@ -style: - ReturnCount: - max: 3 diff --git a/ndk/lib/build.gradle.kts b/ndk/lib/build.gradle.kts index 182b47d88..f14ce9a72 100644 --- a/ndk/lib/build.gradle.kts +++ b/ndk/lib/build.gradle.kts @@ -78,14 +78,7 @@ android { lint { warningsAsErrors = true checkDependencies = true - - // We run a full lint analysis as build part in CI, so skip vital checks for assemble tasks. - checkReleaseBuilds = false - } - - // needed because of Kotlin 1.4.x - configurations.all { - resolutionStrategy.force("org.jetbrains:annotations:23.0.0") + checkReleaseBuilds = true } variantFilter {