[WIP] Add option to client for SDK specific identifier #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I am not sure about this. What about if we do something similiar like in #710 but instead of changing ClientBuilder so deeply I really don't want that the sdk identifer / version is a option the user can set. |
|
Client inheritance would still open the possibility of extension to the end user, so we would still not be able to block that.. |
|
I think we can close this right? Edit: Please delete the branch if we don't need it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP to propose an alternative approach to #710. I have to add a lot of stuff (tests, same stuff in the client builder) before proceeding, but I would like to ask if this approach seems good.