Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jul 2, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Bumps to the latest getsentry/action-app-sdk-overhead-metrics (similar to getsentry/sentry-cocoa#5540) that includes getsentry/action-app-sdk-overhead-metrics#24 to fix the failed metrics CI tests

💡 Motivation and Context

Failed CI (example)

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

When a new version is available we can point to it instead of the hash

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 401.36 ms 413.69 ms 12.33 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0e42017 402.23 ms 415.04 ms 12.81 ms
866f143 594.27 ms 602.00 ms 7.73 ms
38a1af2 404.02 ms 419.89 ms 15.86 ms
e12044e 453.78 ms 437.58 ms -16.20 ms
9167f73 376.63 ms 384.86 ms 8.23 ms
9e3030a 421.47 ms 418.65 ms -2.82 ms
1f1c420 403.32 ms 411.98 ms 8.66 ms
4e2cbd2 427.50 ms 462.78 ms 35.28 ms
ec2a485 450.84 ms 447.49 ms -3.35 ms
7d3c3cb 444.85 ms 456.65 ms 11.81 ms

App size

Revision Plain With Sentry Diff
0e42017 17.75 MiB 20.15 MiB 2.40 MiB
866f143 17.75 MiB 20.15 MiB 2.40 MiB
38a1af2 17.75 MiB 20.15 MiB 2.40 MiB
e12044e 17.75 MiB 20.15 MiB 2.40 MiB
9167f73 17.75 MiB 20.15 MiB 2.40 MiB
9e3030a 17.75 MiB 20.15 MiB 2.40 MiB
1f1c420 17.75 MiB 20.15 MiB 2.40 MiB
4e2cbd2 17.75 MiB 20.15 MiB 2.40 MiB
ec2a485 17.75 MiB 20.15 MiB 2.40 MiB
7d3c3cb 17.75 MiB 20.15 MiB 2.40 MiB

Previous results on branch: antonis/ci-metrics-bumb

Startup times

Revision Plain With Sentry Diff
9fe441b 422.54 ms 417.49 ms -5.05 ms

App size

Revision Plain With Sentry Diff
9fe441b 17.75 MiB 20.15 MiB 2.40 MiB

@antonis antonis marked this pull request as ready for review July 2, 2025 07:03
@antonis antonis requested a review from lucas-zimerman as a code owner July 2, 2025 07:03
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1245.33 ms 1245.56 ms 0.24 ms
Size 3.19 MiB 4.36 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1f1c420+dirty 1238.06 ms 1234.04 ms -4.02 ms
9167f73+dirty 1219.47 ms 1234.39 ms 14.92 ms
b4d6bde+dirty 1218.73 ms 1223.26 ms 4.53 ms
940bd65+dirty 1224.39 ms 1215.57 ms -8.82 ms
e12044e+dirty 1234.49 ms 1228.85 ms -5.64 ms
9e3030a+dirty 1217.82 ms 1205.60 ms -12.21 ms
398e5d0+dirty 1226.17 ms 1232.82 ms 6.65 ms
bdb324a+dirty 1230.02 ms 1226.18 ms -3.84 ms
ec2a485+dirty 1209.65 ms 1229.18 ms 19.53 ms
bd87539+dirty 1233.71 ms 1229.77 ms -3.94 ms

App size

Revision Plain With Sentry Diff
1f1c420+dirty 3.19 MiB 4.34 MiB 1.16 MiB
9167f73+dirty 3.19 MiB 4.35 MiB 1.17 MiB
b4d6bde+dirty 3.19 MiB 4.34 MiB 1.16 MiB
940bd65+dirty 3.19 MiB 4.35 MiB 1.16 MiB
e12044e+dirty 3.19 MiB 4.35 MiB 1.17 MiB
9e3030a+dirty 3.19 MiB 4.35 MiB 1.17 MiB
398e5d0+dirty 3.19 MiB 4.35 MiB 1.17 MiB
bdb324a+dirty 3.19 MiB 4.35 MiB 1.17 MiB
ec2a485+dirty 3.19 MiB 4.35 MiB 1.17 MiB
bd87539+dirty 3.19 MiB 4.36 MiB 1.17 MiB

Previous results on branch: antonis/ci-metrics-bumb

Startup times

Revision Plain With Sentry Diff
9fe441b+dirty 1245.16 ms 1253.84 ms 8.68 ms

App size

Revision Plain With Sentry Diff
9fe441b+dirty 3.19 MiB 4.36 MiB 1.17 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1232.35 ms 1228.47 ms -3.89 ms
Size 2.63 MiB 3.80 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9167f73+dirty 1230.79 ms 1230.63 ms -0.17 ms
940bd65+dirty 1216.88 ms 1225.23 ms 8.35 ms
df5da5d+dirty 1235.98 ms 1243.41 ms 7.43 ms
6e8a851+dirty 1227.96 ms 1235.61 ms 7.65 ms
e12044e+dirty 1233.45 ms 1233.66 ms 0.21 ms
0e42017+dirty 1225.89 ms 1231.63 ms 5.74 ms
8bd8033+dirty 1213.33 ms 1220.88 ms 7.55 ms
1f1c420+dirty 1216.77 ms 1214.48 ms -2.29 ms
9e3030a+dirty 1215.35 ms 1234.80 ms 19.45 ms
398e5d0+dirty 1225.30 ms 1219.94 ms -5.36 ms

App size

Revision Plain With Sentry Diff
9167f73+dirty 2.63 MiB 3.79 MiB 1.15 MiB
940bd65+dirty 2.63 MiB 3.78 MiB 1.15 MiB
df5da5d+dirty 2.63 MiB 3.78 MiB 1.15 MiB
6e8a851+dirty 2.63 MiB 3.78 MiB 1.15 MiB
e12044e+dirty 2.63 MiB 3.78 MiB 1.15 MiB
0e42017+dirty 2.63 MiB 3.78 MiB 1.15 MiB
8bd8033+dirty 2.63 MiB 3.78 MiB 1.15 MiB
1f1c420+dirty 2.63 MiB 3.77 MiB 1.14 MiB
9e3030a+dirty 2.63 MiB 3.79 MiB 1.15 MiB
398e5d0+dirty 2.63 MiB 3.79 MiB 1.15 MiB

Previous results on branch: antonis/ci-metrics-bumb

Startup times

Revision Plain With Sentry Diff
9fe441b+dirty 1226.63 ms 1235.84 ms 9.21 ms

App size

Revision Plain With Sentry Diff
9fe441b+dirty 2.63 MiB 3.80 MiB 1.17 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 373.04 ms 374.40 ms 1.36 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
df5da5d+dirty 415.54 ms 456.96 ms 41.42 ms
bdb324a+dirty 401.10 ms 401.16 ms 0.06 ms
7d3c3cb+dirty 395.20 ms 413.24 ms 18.04 ms
9167f73+dirty 372.49 ms 389.90 ms 17.41 ms
e12044e+dirty 404.20 ms 398.15 ms -6.06 ms
4e2cbd2+dirty 371.98 ms 392.00 ms 20.02 ms
38a1af2+dirty 421.38 ms 431.35 ms 9.97 ms
6e8a851+dirty 403.44 ms 430.87 ms 27.43 ms
b4d6bde+dirty 390.51 ms 385.60 ms -4.91 ms
bd87539+dirty 388.51 ms 370.56 ms -17.95 ms

App size

Revision Plain With Sentry Diff
df5da5d+dirty 7.15 MiB 8.42 MiB 1.26 MiB
bdb324a+dirty 7.15 MiB 8.42 MiB 1.26 MiB
7d3c3cb+dirty 7.15 MiB 8.42 MiB 1.26 MiB
9167f73+dirty 7.15 MiB 8.42 MiB 1.26 MiB
e12044e+dirty 7.15 MiB 8.42 MiB 1.26 MiB
4e2cbd2+dirty 7.15 MiB 8.42 MiB 1.26 MiB
38a1af2+dirty 7.15 MiB 8.42 MiB 1.26 MiB
6e8a851+dirty 7.15 MiB 8.42 MiB 1.26 MiB
b4d6bde+dirty 7.15 MiB 8.42 MiB 1.26 MiB
bd87539+dirty 7.15 MiB 8.42 MiB 1.26 MiB

Previous results on branch: antonis/ci-metrics-bumb

Startup times

Revision Plain With Sentry Diff
9fe441b+dirty 407.94 ms 407.41 ms -0.53 ms

App size

Revision Plain With Sentry Diff
9fe441b+dirty 7.15 MiB 8.42 MiB 1.26 MiB

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis enabled auto-merge (squash) July 2, 2025 11:08
@antonis antonis merged commit f76175c into main Jul 2, 2025
65 checks passed
@antonis antonis deleted the antonis/ci-metrics-bumb branch July 2, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants