Remove extra imports #5287
Merged
Remove extra imports #5287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
noahsmartin
force-pushed
the
removeExtraImport
branch
from
8055b2f to
064c916
Compare
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20d5eaa | 377.62 ms | 406.50 ms | 28.88 ms |
| c08359e | 421.87 ms | 445.37 ms | 23.50 ms |
| 8490686+dirty | 365.59 ms | 400.24 ms | 34.65 ms |
| c1573b3 | 400.85 ms | 411.82 ms | 10.97 ms |
| c4e097a | 338.06 ms | 439.36 ms | 101.30 ms |
| 07808fb+dirty | 419.10 ms | 419.08 ms | -0.02 ms |
| 49ef936+dirty | 405.96 ms | 417.22 ms | 11.26 ms |
| a31630c+dirty | 408.91 ms | 416.80 ms | 7.89 ms |
| 459a438+dirty | 417.09 ms | 406.52 ms | -10.57 ms |
| 05bef0e+dirty | 349.78 ms | 334.04 ms | -15.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 20d5eaa | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| c08359e | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 8490686+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| c1573b3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| c4e097a | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 07808fb+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 49ef936+dirty | 17.75 MiB | 19.69 MiB | 1.94 MiB |
| a31630c+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 459a438+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 05bef0e+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
noahsmartin
force-pushed
the
removeExtraImport
branch
from
064c916 to
fae7a66
Compare
noahsmartin
force-pushed
the
removeExtraImport
branch
from
fae7a66 to
6f624b2
Compare
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90afdd3+dirty | 1233.90 ms | 1240.90 ms | 7.00 ms |
| 21c9e75+dirty | 1237.78 ms | 1247.66 ms | 9.88 ms |
| 6fee48d+dirty | 1222.14 ms | 1231.44 ms | 9.30 ms |
| 170d5ea+dirty | 1219.27 ms | 1231.90 ms | 12.63 ms |
| 1853710+dirty | 1224.35 ms | 1230.18 ms | 5.84 ms |
| bc9680d+dirty | 1221.41 ms | 1241.47 ms | 20.06 ms |
| 20d5eaa+dirty | 1231.12 ms | 1226.00 ms | -5.12 ms |
| 276d348+dirty | 1224.22 ms | 1227.38 ms | 3.16 ms |
| c7f264b+dirty | 1211.82 ms | 1218.04 ms | 6.22 ms |
| a31630c+dirty | 1229.09 ms | 1230.94 ms | 1.85 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90afdd3+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 21c9e75+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 6fee48d+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 170d5ea+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| 1853710+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| bc9680d+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 20d5eaa+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 276d348+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| c7f264b+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| a31630c+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90afdd3+dirty | 1216.17 ms | 1225.55 ms | 9.38 ms |
| 21c9e75+dirty | 1206.20 ms | 1223.54 ms | 17.35 ms |
| 6fee48d+dirty | 1208.85 ms | 1218.52 ms | 9.67 ms |
| 170d5ea+dirty | 1233.96 ms | 1242.54 ms | 8.58 ms |
| 1853710+dirty | 1213.67 ms | 1226.35 ms | 12.67 ms |
| bc9680d+dirty | 1228.57 ms | 1233.64 ms | 5.07 ms |
| 20d5eaa+dirty | 1224.67 ms | 1223.16 ms | -1.51 ms |
| 276d348+dirty | 1222.10 ms | 1229.02 ms | 6.92 ms |
| c7f264b+dirty | 1229.78 ms | 1225.84 ms | -3.94 ms |
| a31630c+dirty | 1241.32 ms | 1226.98 ms | -14.34 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 90afdd3+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 21c9e75+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 6fee48d+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| 170d5ea+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| 1853710+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| bc9680d+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 20d5eaa+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 276d348+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| c7f264b+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| a31630c+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8490686+dirty | 344.38 ms | 364.37 ms | 19.98 ms |
| 20daa0a+dirty | 352.33 ms | 424.30 ms | 71.98 ms |
| 818a608+dirty | 350.29 ms | 397.38 ms | 47.09 ms |
| 69602ce+dirty | 375.37 ms | 405.28 ms | 29.91 ms |
| b3b5b0d+dirty | 361.42 ms | 403.90 ms | 42.48 ms |
| 07808fb+dirty | 392.47 ms | 451.94 ms | 59.47 ms |
| 49ef936+dirty | 333.72 ms | 387.51 ms | 53.79 ms |
| a31630c+dirty | 359.89 ms | 416.90 ms | 57.00 ms |
| 459a438+dirty | 359.50 ms | 390.53 ms | 31.03 ms |
| 05bef0e+dirty | 451.63 ms | 533.90 ms | 82.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8490686+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 20daa0a+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 818a608+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 69602ce+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| b3b5b0d+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 07808fb+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 49ef936+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| a31630c+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 459a438+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 05bef0e+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
antonis
approved these changes
Oct 22, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM 🎸
Thank you for keeping in sync the React-Native SDK 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some imports, and replace one with
@importsince the .h file was deleted#skip-changelog