ref(span-buffer): Move max-memory-percentage to right CLI (#91924)

This was added to the wrong CLI, and because it's an optional argument
in the factory this wasn't noticed during manual testing.

Author: untitaker

src/sentry/consumers/__init__.py

@@ -424,6 +424,11 @@ def ingest_transactions_options() -> list[click.Option]:
                 default=100,
                 help="The number of segments to download from redis at once. Defaults to 100.",
             ),
+            click.Option(
+                ["--max-memory-percentage", "max_memory_percentage"],
+                default=1.0,
+                help="Maximum memory usage of the Redis cluster in % (0.0-1.0) before the consumer backpressures.",
+            ),
             *multiprocessing_options(default_max_batch_size=100),
         ],
     },
@@ -436,11 +441,6 @@ def ingest_transactions_options() -> list[click.Option]:
                 is_flag=True,
                 default=False,
             ),
-            click.Option(
-                ["--max-memory-percentage", "max_memory_percentage"],
-                default=1.0,
-                help="Maximum memory usage of the Redis cluster in % (0.0-1.0) before the consumer backpressures.",
-            ),
             *multiprocessing_options(default_max_batch_size=100),
         ],
     },