Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite OriginsField to use a custom validator #1057

Closed
mattrobenolt opened this issue Nov 12, 2013 · 3 comments
Closed

Rewrite OriginsField to use a custom validator #1057

mattrobenolt opened this issue Nov 12, 2013 · 3 comments
Assignees

Comments

@mattrobenolt
Copy link
Contributor

This will allow us to wrap up all of the logic in one place instead of treating it like a URLField.

This will let us solve some of the issues around weird urls that happen from raven.js, like chrome-extension://.

See: getsentry/sentry-javascript#157

@ghost ghost assigned mattrobenolt Nov 12, 2013
@mattrobenolt mattrobenolt added this to the 8.2 Release milestone Feb 12, 2016
@mattrobenolt
Copy link
Contributor Author

Need to look at this again to see if it's still a problem.

@benvinegar benvinegar modified the milestone: 8.2 Release Mar 2, 2016
@mack7121
Copy link

If this is still an issue, I want to help.

@dcramer
Copy link
Member

dcramer commented Sep 22, 2016

Doesn't look like this is still a problem, as we have simple custom URL parsing here.

@dcramer dcramer closed this as completed Sep 22, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants