From b4cb3c973e8ced4c5c8716a1570a9565581bd9be Mon Sep 17 00:00:00 2001
From: Scott Cooper <scttcper@gmail.com>
Date: Fri, 10 Oct 2025 12:01:22 -0700
Subject: [PATCH] fix(aci): Remove hardcoded `event.type:transactions` from
 query

We were adding `event.type:transactions` to transaction detectors, but it doesn't seem necessary and displays an error in the filter..
---
 .../datasetConfig/transactions.spec.tsx       | 34 ++-----------------
 .../detectors/datasetConfig/transactions.tsx  | 12 +------
 2 files changed, 3 insertions(+), 43 deletions(-)

diff --git a/static/app/views/detectors/datasetConfig/transactions.spec.tsx b/static/app/views/detectors/datasetConfig/transactions.spec.tsx
index 0c175f3da82c33..8cc2826a339e12 100644
--- a/static/app/views/detectors/datasetConfig/transactions.spec.tsx
+++ b/static/app/views/detectors/datasetConfig/transactions.spec.tsx
@@ -5,36 +5,6 @@ import {Dataset, EventTypes} from 'sentry/views/alerts/rules/metric/types';
 import {DetectorTransactionsConfig} from 'sentry/views/detectors/datasetConfig/transactions';
 
 describe('DetectorTransactionsConfig', () => {
-  describe('toSnubaQueryString', () => {
-    it('passes through when already contains event.type:transaction', () => {
-      const query = 'event.type:transaction transaction.duration:>0';
-      expect(
-        DetectorTransactionsConfig.toSnubaQueryString({
-          eventTypes: [EventTypes.TRANSACTION],
-          query,
-        })
-      ).toBe(query);
-    });
-
-    it('prefixes event.type:transaction when missing', () => {
-      const query = 'transaction.duration:>0 service:web';
-      expect(
-        DetectorTransactionsConfig.toSnubaQueryString({
-          eventTypes: [EventTypes.TRANSACTION],
-          query,
-        })
-      ).toBe(`event.type:transaction ${query}`);
-    });
-  });
-
-  describe('getDiscoverDataset', () => {
-    it('returns METRICS_ENHANCED for transactions', () => {
-      expect(DetectorTransactionsConfig.getDiscoverDataset()).toBe(
-        DiscoverDatasets.METRICS_ENHANCED
-      );
-    });
-  });
-
   describe('getSeriesQueryOptions', () => {
     const organization = OrganizationFixture();
 
@@ -55,7 +25,7 @@ describe('DetectorTransactionsConfig', () => {
       expect(key[0]).toBe(`/organizations/${organization.slug}/events-stats/`);
       const params = key[1]!.query!;
       expect(params.dataset).toBe(DiscoverDatasets.METRICS_ENHANCED);
-      expect(params.query).toBe('event.type:transaction transaction.duration:>0');
+      expect(params.query).toBe('transaction.duration:>0');
       expect(params.interval).toBe('1m');
       expect(params.environment).toEqual(['prod']);
       expect(params.project).toEqual(['1']);
@@ -99,7 +69,7 @@ describe('DetectorTransactionsConfig', () => {
 
       const params = key[1]!.query!;
       expect(params.dataset).toBe(DiscoverDatasets.METRICS_ENHANCED);
-      expect(params.query).toBe('event.type:transaction transaction.duration:>0');
+      expect(params.query).toBe('transaction.duration:>0');
       expect(params.interval).toBe('1m');
     });
   });
diff --git a/static/app/views/detectors/datasetConfig/transactions.tsx b/static/app/views/detectors/datasetConfig/transactions.tsx
index 5b7b0d65914656..b740d4bce00684 100644
--- a/static/app/views/detectors/datasetConfig/transactions.tsx
+++ b/static/app/views/detectors/datasetConfig/transactions.tsx
@@ -113,17 +113,7 @@ export const DetectorTransactionsConfig: DetectorDatasetConfig<TransactionsSerie
     getTimePeriods: interval => getStandardTimePeriodsForInterval(interval),
     separateEventTypesFromQuery: query =>
       parseEventTypesFromQuery(query, DEFAULT_EVENT_TYPES),
-    toSnubaQueryString: snubaQuery => {
-      if (!snubaQuery) {
-        return '';
-      }
-
-      if (snubaQuery.query.includes('event.type:transaction')) {
-        return snubaQuery.query;
-      }
-
-      return `event.type:transaction ${snubaQuery.query}`;
-    },
+    toSnubaQueryString: snubaQuery => snubaQuery?.query ?? '',
     transformSeriesQueryData: (data, aggregate) => {
       return [transformEventsStatsToSeries(data, aggregate)];
     },