From 2b2118965b6fd1522e883c1a22f371d1a18b174c Mon Sep 17 00:00:00 2001 From: chrissy Date: Thu, 17 Jan 2019 12:30:11 -0800 Subject: [PATCH] actually solve background bug in onboarding and revert old fix that didn't really fix it --- .../sentry/app/views/onboarding/index.jsx | 22 +- src/sentry/static/sentry/less/onboarding.less | 1 + .../__snapshots__/index.spec.jsx.snap | 3712 +++++++++-------- 3 files changed, 1880 insertions(+), 1855 deletions(-) diff --git a/src/sentry/static/sentry/app/views/onboarding/index.jsx b/src/sentry/static/sentry/app/views/onboarding/index.jsx index 3bb260c7edde42..8ee40ae8a04c6e 100644 --- a/src/sentry/static/sentry/app/views/onboarding/index.jsx +++ b/src/sentry/static/sentry/app/views/onboarding/index.jsx @@ -1,6 +1,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import DocumentTitle from 'react-document-title'; +import styled from 'react-emotion'; import ProgressNodes from 'app/views/onboarding/progress'; @@ -11,15 +12,24 @@ class OnboardingWizard extends React.Component { render() { return ( -
- -
- -
{this.props.children}
+ +
+ +
+ +
{this.props.children}
+
-
+ ); } } +const OnboardingBackground = styled('div')` + width: 100%; + height: 100%; + min-height: 100vh; + background: #fff; +`; + export default OnboardingWizard; diff --git a/src/sentry/static/sentry/less/onboarding.less b/src/sentry/static/sentry/less/onboarding.less index 050f099563c0c0..47499ee5022359 100644 --- a/src/sentry/static/sentry/less/onboarding.less +++ b/src/sentry/static/sentry/less/onboarding.less @@ -167,6 +167,7 @@ position: sticky; bottom: 0; + background: white; p { margin-top: 20px; diff --git a/tests/js/spec/views/onboarding/__snapshots__/index.spec.jsx.snap b/tests/js/spec/views/onboarding/__snapshots__/index.spec.jsx.snap index d6e5fe29558832..2db8faac0bbc78 100644 --- a/tests/js/spec/views/onboarding/__snapshots__/index.spec.jsx.snap +++ b/tests/js/spec/views/onboarding/__snapshots__/index.spec.jsx.snap @@ -1,25 +1,27 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`OnboardingWizard render() should render NotFound if no matching organization 1`] = ` -
- +
- -
+
+ +
+
-
+ `; exports[`OnboardingWizard render() should render and respond to click events 1`] = ` @@ -36,920 +38,895 @@ exports[`OnboardingWizard render() should render and respond to click events 1`] } } > -
- - - +
- + + +
-
- -
-
- - Create an organization in Sentry -
-
- - Tell us about your project -
-
- - Configure your application and send an event -
-
- -
-
-
- -
- - + +
+
+
+ + Create an organization in Sentry +
+
+ + Tell us about your project +
+
+ + Configure your application and send an event +
+
+
-

- Choose a language or framework: -

- - - + Stuck? +

+

+ Ask for help +

+ +
+
+ +
+
- -
    + -
  • -
    - - -
    -
  • - -
  • + + + +
    + + - - + +
      - -
    • - -
    • -
      -
      - - C# - -
      - - - - - +
    • + +
    • +
      +
      + + C# + +
      +
      +
      + -
    • - -
    • - -
      - - Java - -
      - -
      - - - +
    • + +
    • +
      +
      + + Java + +
      +
      +
      + -
    • - -
    • - -
      - - Angular - -
      - -
      - - - +
    • + +
    • +
      +
      + + Angular + +
      +
      +
      + -
    • - -
    • - -
      - - JavaScript - -
      - -
      - - - +
    • + +
    • +
      +
      + + JavaScript + +
      +
      +
      + -
    • - -
    • - -
      - - React - -
      - -
      - - - +
    • + +
    • +
      +
      + + React + +
      +
      +
      + -
    • - -
    • - -
      - - Express - -
      - -
      - - - +
    • + +
    • +
      +
      + + Express + +
      +
      +
      + -
    • - -
    • - -
      - - Node.js - -
      - -
      - - - +
    • + +
    • +
      +
      + + Node.js + +
      +
      +
      + -
    • - -
    • - -
      - - Laravel - -
      - -
      - - - +
    • + +
    • +
      +
      + + Laravel + +
      +
      +
      + -
    • - -
    • - -
      - - PHP - -
      - -
      - - - +
    • + +
    • +
      +
      + + PHP + +
      +
      +
      + -
    • - -
    • - -
      - - Symfony2 - -
      - -
      - - - +
    • + +
    • +
      +
      + + Symfony2 + +
      +
      +
      + -
    • - -
    • - -
      - - Django - -
      - -
      - - - +
    • + +
    • +
      +
      + + Django + +
      +
      +
      + -
    • - -
    • - -
      - - Flask - -
      - -
      - - - +
    • + +
    • +
      +
      + + Flask + +
      +
      +
      + -
    • - -
    • - -
      - - Python - -
      - -
      - - - +
    • + +
    • +
      +
      + + Python + +
      +
      +
      + + + +
    • + +
    • +
      +
      + + React-Native + +
      +
      +
      + -
    • - -
    • - -
      - - React-Native - -
      - -
      - - - +
    • + +
    • +
      +
      + + Rails + +
      +
      +
      + -
    • - -
    • - -
      - - Rails - -
      - -
      - +
    • + +
    • + +
      + + Ruby + +
      + +
      +
    +
    +
    +
    +
    - + +

    + Give your project a name: +

    +
    + +
  • -
    - - Ruby - -
    - - -
-
- -
-
- - -

- Give your project a name: -

-
-
-
- -
  • - -
  • -
    - -
    -
    -
    - - +
    +
    -

    - Team: -

    - - -
    - -
    +

    + Team: +

    + + +
    + -
    - - - - - - + Select... +
    +
    - - - - - - -
    + +
    +
    + + + + + + +
    +
    +
    - +
    +
    + +
    +

    + Projects allow you to scope events to a specific application in your organization. For example, you might have separate projects for your API server and frontend client. +

    -
    - -
    -

    - Projects allow you to scope events to a specific application in your organization. For example, you might have separate projects for your API server and frontend client. -

    -
    + - + - + `; @@ -1178,127 +1186,91 @@ exports[`OnboardingWizard render() should render and respond to click events 2`] } } > -
    - - - +
    - + + +
    -
    - -
    -
    -
    - - Create an organization in Sentry -
    -
    - - Tell us about your project -
    -
    - - Configure your application and send an event -
    -
    - -
    -
    -
    - -
    - - + +
    +
    +
    + + Create an organization in Sentry +
    +
    + + Tell us about your project +
    +
    + + Configure your application and send an event +
    +
    +
    -

    - Choose a language or framework: -

    - - - + Stuck? +

    +

    + Ask for help +

    + +
    +
    + +
    +
    - -
      + -
    • -
      - - -
      -
    • - -
    • + + + +
      + + - - + +
        - -
      • - -
      • -
        -
        - - C# - -
        - - - - - +
      • + +
      • +
        +
        + + C# + +
        +
        +
        + -
      • - -
      • - -
        - - Java - -
        - -
        - - - +
      • + +
      • +
        +
        + + Java + +
        +
        +
        + -
      • - -
      • - -
        - - Angular - -
        - -
        - - - +
      • + +
      • +
        +
        + + Angular + +
        +
        +
        + -
      • - -
      • - -
        - - JavaScript - -
        - -
        - - - +
      • + +
      • +
        +
        + + JavaScript + +
        +
        +
        + -
      • - -
      • - -
        - - React - -
        - -
        - - - +
      • + +
      • +
        +
        + + React + +
        +
        +
        + -
      • - -
      • - -
        - - Express - -
        - -
        - - - +
      • + +
      • +
        +
        + + Express + +
        +
        +
        + -
      • - -
      • - -
        - - Node.js - -
        - -
        - - - +
      • + +
      • +
        +
        + + Node.js + +
        +
        +
        + -
      • - -
      • - -
        - - Laravel - -
        - -
        - - - +
      • + +
      • +
        +
        + + Laravel + +
        +
        +
        + -
      • - -
      • - -
        - - PHP - -
        - -
        - - - +
      • + +
      • +
        +
        + + PHP + +
        +
        +
        + -
      • - -
      • - -
        - - Symfony2 - -
        - -
        - - - +
      • + +
      • +
        +
        + + Symfony2 + +
        +
        +
        + -
      • - -
      • - -
        - - Django - -
        - -
        - - - +
      • + +
      • +
        +
        + + Django + +
        +
        +
        + -
      • - -
      • - -
        - - Flask - -
        - -
        - - - +
      • + +
      • +
        +
        + + Flask + +
        +
        +
        + -
      • - -
      • - -
        - - Python - -
        - -
        - - - +
      • + +
      • +
        +
        + + Python + +
        +
        +
        + -
      • - -
      • - -
        - - React-Native - -
        - -
        - - - +
      • + +
      • +
        +
        + + React-Native + +
        +
        +
        + -
      • - -
      • - -
        - - Rails - -
        - -
        - - - +
      • + +
      • +
        +
        + + Rails + +
        +
        +
        + + + +
      • + +
      • +
        +
        + + Ruby + +
        +
        +
        +
      +
      +
      +
      +
      + + +

      + Give your project a name: +

      +
      +
      +
      +
    • -
      - - Ruby - -
      - - -
    -
    - -
    -
    - - -

    - Give your project a name: -

    -
    -
    -
    - -
  • - -
  • -
    - -
    -
    -
    - - +
    +
    -

    - Team: -

    - - -
    - -
    +

    + Team: +

    + + +
    + -
    - - - - - - + Select... +
    +
    - - - - - - -
    + +
    +
    + + + + + + +
    +
    +
    - +
    +
    + +
    +

    + Projects allow you to scope events to a specific application in your organization. For example, you might have separate projects for your API server and frontend client. +

    -
    - -
    -

    - Projects allow you to scope events to a specific application in your organization. For example, you might have separate projects for your API server and frontend client. -

    - + - + - + `;