From b34812a5db2d081350151a62b702bfe029f31285 Mon Sep 17 00:00:00 2001 From: anthony sottile Date: Wed, 8 May 2024 11:36:58 -0400 Subject: [PATCH] ref: remove logging the slack request body --- .../integrations/slack/requests/base.py | 1 - .../integrations/slack/test_requests.py | 21 ------------------- 2 files changed, 22 deletions(-) diff --git a/src/sentry/integrations/slack/requests/base.py b/src/sentry/integrations/slack/requests/base.py index a769106a1740d..b3e7fd11b32f1 100644 --- a/src/sentry/integrations/slack/requests/base.py +++ b/src/sentry/integrations/slack/requests/base.py @@ -147,7 +147,6 @@ def logging_data(self) -> Mapping[str, str]: "slack_callback_id": _data.get("callback_id"), "slack_api_app_id": _data.get("api_app_id"), } - data["request_data"] = _data if self._integration: data["integration_id"] = self.integration.id diff --git a/tests/sentry/integrations/slack/test_requests.py b/tests/sentry/integrations/slack/test_requests.py index 80583a5126ef7..187779c5632d2 100644 --- a/tests/sentry/integrations/slack/test_requests.py +++ b/tests/sentry/integrations/slack/test_requests.py @@ -49,13 +49,6 @@ def test_collects_logging_data(self): "slack_channel_id": "1", "slack_user_id": "2", "slack_api_app_id": "S1", - "request_data": { - "api_app_id": "S1", - "channel": {"id": "1"}, - "team_id": "T001", - "type": "foo", - "user": {"id": "2"}, - }, } def test_disregards_None_logging_values(self): @@ -65,13 +58,6 @@ def test_disregards_None_logging_values(self): "slack_team_id": "T001", "slack_channel_id": "1", "slack_user_id": "2", - "request_data": { - "api_app_id": None, - "channel": {"id": "1"}, - "team_id": "T001", - "type": "foo", - "user": {"id": "2"}, - }, } def test_validate_existence_of_data(self): @@ -122,13 +108,6 @@ def test_none_in_data(self): "slack_channel_id": "1", "slack_user_id": "2", "slack_api_app_id": "S1", - "request_data": { - "api_app_id": "S1", - "channel": {"id": "1"}, - "team": None, - "type": "foo", - "user": {"id": "2"}, - }, }