feat(nestjs): Update nest setup in onboarding #74929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
nicohrubec
changed the title
| @@ -84,11 +96,10 @@ const onboarding: OnboardingConfig = { | |||
| }, | |||
| { | |||
| description: tct( | |||
| 'Make sure to import [code1:instrument.js/mjs] at the top of your [code2:main.ts/js] file. Set up the error handler by passing the [code3:BaseExceptionFilter].', | |||
| 'Make sure to import [code1:instrument.js/mjs] at the top of your [code2:main.ts/js] file.', | |||
There was a problem hiding this comment.
now we are displaying 2x 'Make sure'... do we need both?
priscilawebdev
approved these changes
Jul 30, 2024
roaga
pushed a commit
that referenced
this pull request
Jul 31, 2024
related to getsentry/sentry-javascript#12920 There is a new way to setup the nest SDK. Updating the product onboarding accordingly. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to getsentry/sentry-javascript#12920
There is a new way to setup the nest SDK. Updating the product onboarding accordingly.