feat(crons): Add mark_unknown clock tick task
#79735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79735 +/- ##
==========================================
+ Coverage 78.41% 78.46% +0.04%
==========================================
Files 7147 7159 +12
Lines 315845 316764 +919
Branches 43498 43608 +110
==========================================
+ Hits 247685 248537 +852
- Misses 61825 61878 +53
- Partials 6335 6349 +14 |
This was referenced Oct 25, 2024
This task will be used when the clock ticks with the volume_anomaly_result set to `abnormal`. In this scenario we must mark ALL in-progress check-ins as "unknown", since we cannot be sure that the completing check-in was not sent during the lost data that caused the volume drop of check-ins.
evanpurkhiser
force-pushed
the
evanpurkhiser/feat-crons-add-mark-unknown-clock-tick-task
branch
from
1d49328
to
bc93d79
Compare
JoshFerge
reviewed
Nov 6, 2024
| # | ||
| # NOTE: We should keep an eye on this as we have more and more usage of | ||
| # monitors the larger the number of checkins to check will exist. | ||
| CHECKINS_LIMIT = 10_000 |
There was a problem hiding this comment.
note: this is the same as in other tasks.
JoshFerge
reviewed
Nov 6, 2024
Co-authored-by: Josh Ferge <josh.ferge@sentry.io>
JoshFerge
approved these changes
Nov 6, 2024
evanpurkhiser
deleted the
evanpurkhiser/feat-crons-add-mark-unknown-clock-tick-task
branch
evanpurkhiser
added a commit
that referenced
this pull request
Nov 6, 2024
This causes clock ticks with the "volume_anomaly_result" set as abnormal to dispatch a mark_unknown task instead of a check_timeouts task. This is needed since when we detect an anomalous tick we're unable to know if we lost customer data during that tick, meaning all in-progress check-ins that were waiting for closing check-ins must now be invalidated with a status of unknown. Part of GH-79328 Requires #79735
saponifi3d
pushed a commit
that referenced
this pull request
Nov 7, 2024
This causes clock ticks with the "volume_anomaly_result" set as abnormal to dispatch a mark_unknown task instead of a check_timeouts task. This is needed since when we detect an anomalous tick we're unable to know if we lost customer data during that tick, meaning all in-progress check-ins that were waiting for closing check-ins must now be invalidated with a status of unknown. Part of GH-79328 Requires #79735
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task will be used when the clock ticks with the
volume_anomaly_result set to
abnormal. In this scenario we must markALL in-progress check-ins as "unknown", since we cannot be sure that the
completing check-in was not sent during the lost data that caused the
volume drop of check-ins.
Part of GH-79328