feat(mdc): Remove default entity from base Dataset class #3142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enochtangg
force-pushed
the
remove_default_entity
branch
from
35df546 to
2687ad1
Compare
enochtangg
changed the title
lynnagara
reviewed
Sep 14, 2022
enochtangg
force-pushed
the
remove_default_entity
branch
from
2687ad1 to
02a0f28
Compare
Codecov ReportBase: 92.78% // Head: 92.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #3142 +/- ##
==========================================
- Coverage 92.78% 92.77% -0.01%
==========================================
Files 677 678 +1
Lines 30968 31007 +39
==========================================
+ Hits 28733 28768 +35
- Misses 2235 2239 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lynnagara
reviewed
Sep 14, 2022
lynnagara
reviewed
Sep 14, 2022
enochtangg
changed the title
enochtangg
force-pushed
the
remove_default_entity
branch
2 times, most recently
from
9c20561 to
91c4d0f
Compare
enochtangg
force-pushed
the
remove_default_entity
branch
2 times, most recently
from
2bd8a9c to
e45d32c
Compare
enochtangg
force-pushed
the
remove_default_entity
branch
from
e45d32c to
14dcb99
Compare
lynnagara
reviewed
Sep 15, 2022
lynnagara
approved these changes
Sep 16, 2022
enochtangg
added a commit
to getsentry/sentry
that referenced
this pull request
Sep 19, 2022
This PR is responsible for updating the Snuba eventstream and insert
test endpoints
* From: `POST /tests/{dataset}/eventstream` To: `POST
/tests/{entity}/eventstream`
* From: `POST /tests/{dataset}/insert` To: `POST
/tests/entities/{entity}/insert`
This change is required due to the removal of the `default_entity`
attribute in the Dataset class in Snuba. As a result, every request sent
to Snuba (e.g. query, eventstream, etc.) must specify both a dataset and
entity.
The changes to the server endpoint is specified here:
getsentry/snuba#3142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all queries sent to Snuba specify an Entity, we want to remove the legacy
default_entityattribute in a Dataset.This PR is responsible for the following:
default_entityfrom base Dataset class and its get method.allsub-property.all_entitiesattribute to dataset base class and pass entity keys to child initializationget_default_entityoccurrences in tests and added support where neededdefault_entityand dataset parameter altogether. Plan to re-route to new endpoints are specified here: ref(MDC): Update Snuba eventstream and insert endpoints sentry#38877