-
Notifications
You must be signed in to change notification settings - Fork 0
Initial commits #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR establishes the foundational infrastructure for the dataframe-expectations repository by adding comprehensive test coverage for the library's core functionality and setting up essential development tools.
Key changes:
- Comprehensive test suite covering expectations, result messages, and helper classes
- Sphinx documentation generator configuration
- Pre-commit hooks for code quality
- GitHub workflow for CI/CD automation
Reviewed Changes
Copilot reviewed 75 out of 84 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_result_message.py | Tests for result message classes covering success/failure scenarios for pandas and PySpark |
| tests/test_expectations_suite.py | Tests for expectation suite functionality including success/failure cases and dataframe type handling |
| tests/expectations_implemented/template_test_expectation.py | Template test file defining standard test patterns for new expectations |
| tests/expectations_implemented/column_expectations/string_expectations/*.py | Comprehensive tests for string-based column expectations (starts_with, ends_with, contains, length validations) |
| tests/expectations_implemented/column_expectations/numerical_expectations/*.py | Tests for numerical column expectations (greater_than, less_than, between) |
| tests/expectations_implemented/column_expectations/any_value_expectations/*.py | Tests for generic value expectations (null checks, equality, set membership) |
| tests/expectations_implemented/aggregation_expectations/numerical_expectations/*.py | Tests for aggregated numerical expectations (mean, median, min, max, quantile) |
| tests/expectations_implemented/aggregation_expectations/any_value_expectations/*.py | Tests for row-level and percentage-based expectations (row counts, uniqueness, null percentages) |
| tests/expectations_helper_classes/*.py | Tests for utility functions and expectation registry mechanisms |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
alexbbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point look good enough to me (though I didn't really review the code -- there is too much)
Initial Commits
This pull request sets up the initial structure for the
dataframe-expectationsrepository. Key additions include:These changes establish the foundational tools and processes for the repository, preparing it for further development and collaboration.