Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotation mark bug fix in docs #2005

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Quotation mark bug fix in docs #2005

merged 1 commit into from
Oct 30, 2022

Conversation

YesSeri
Copy link
Contributor

@YesSeri YesSeri commented Oct 14, 2022

Changed double quotation mark " to single quotation ', otherwise the code doesn't work.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changed double quotation mark " to single quotation ', otherwise the code doesn't work.
@YesSeri YesSeri changed the title Quotation mark bug fix Quotation mark bug fix in docs Oct 14, 2022
@Keats
Copy link
Collaborator

Keats commented Oct 15, 2022

Why would double quotes not work? I'm only using them everywhere

@YesSeri
Copy link
Contributor Author

YesSeri commented Oct 16, 2022

I should have been more clear in my communication.

"{{/* get_url(path="@/blog/_index.md") */}}"

You have nested quotation marks here. That means that the code above gets interpreted as

// Text
"{{/* get_url(path="
//Html
@/blog/_index.md
// Text
") */}}"

Does my example make sense?

I think it is only a problem here, but if you accept my pull request I can look through all of the documentation for similar problems.

What do you think?

@Keats
Copy link
Collaborator

Keats commented Oct 16, 2022

Why would you have newlines in there?

@YesSeri
Copy link
Contributor Author

YesSeri commented Oct 17, 2022

There should not be newlines. I was just trying to emphasize my point. Do you understand why the code doesn't work?

@Keats
Copy link
Collaborator

Keats commented Oct 21, 2022

I don't sorry, I must be dense 😿

@jtojnar
Copy link

jtojnar commented Oct 23, 2022

Perhaps @YesSeri means syntax highlighting is broken in some editors?

@jtojnar
Copy link

jtojnar commented Oct 30, 2022

Actually, it even breaks syntax highlighting on the website:

Bottom of the Overview page

@Keats Keats merged commit 53cf920 into getzola:master Oct 30, 2022
@YesSeri
Copy link
Contributor Author

YesSeri commented Dec 5, 2022

Actually, it even breaks syntax highlighting on the website:

Bottom of the Overview page

Well, the syntax highlightning is broken because the code is broken. If you want to nest double quotation marks you need a way to escape them or you can use single quotation marks.

Newbytee pushed a commit to Newbytee/zola that referenced this pull request Feb 16, 2023
Changed double quotation mark " to single quotation ', otherwise the code doesn't work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants