Avoid unnecessary checking for already checked links #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biodranik
force-pushed
the
faster-links-checking
branch
2 times, most recently
from
908ee39
to
042de39
Compare
3 tasks
Keats
requested changes
Sep 13, 2023
biodranik
force-pushed
the
faster-links-checking
branch
from
042de39
to
a4ee351
Compare
|
@Keats done, PTAL |
|
To fix the CI issue, you can run |
biodranik
force-pushed
the
faster-links-checking
branch
from
a4ee351
to
c7dffdf
Compare
|
Thanks! Also |
Keats
approved these changes
Sep 17, 2023
|
Some of the code can be cleaned up a bit, I'll post a link to the commit after doing it. |
|
@Keats Thanks! You can also leave suggestions if it's easier ) |
technimad
pushed a commit
to technimad/zola
that referenced
this pull request
Sep 30, 2023
* Fixed "unnecessary mut" warning * Fixed minor typo * Use more than 8 threads for links checking if hardware supports it * Fixed failing azure Linux check * Avoid unnecessary HTTP requests to the same, already checked links
Keats
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Fixed "unnecessary mut" warning * Fixed minor typo * Use more than 8 threads for links checking if hardware supports it * Fixed failing azure Linux check * Avoid unnecessary HTTP requests to the same, already checked links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2298
For localized Organic Maps zola site the time for
zola checklink checking has reduced from 3 minutes to less than 1 minute.I'm new to Rust, so any ideas on how to write better code are welcome!