ci: Run clippy -Dwarnings and use minimal toolchain profile
#223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msiglreith Can we get this in? |
MarijnS95
commented
Nov 1, 2024
| @@ -6,6 +6,7 @@ authors = [ | |||
| "Lei Zhang <antiagainst@gmail.com>", | |||
| ] | |||
| edition = "2018" | |||
| rust-version = "1.58" | |||
There was a problem hiding this comment.
3 years later, I don't understand why I added this: autogen is the only crate that is not published and shouldn't care about the version at all, since Rust developers contributing to this repository and specifically using the generator to regenerate its contents can easily use the latest stable at all times.
MarijnS95
added a commit
that referenced
this pull request
Nov 1, 2024
Specifically `rust-version = "1.58"` in the `autogen` module that I added in #223 is weird, since any developers working on and/or contributing to the repository should easily be able to run the latest stable and take advantage of newer Rust features in `autogen` code.
MarijnS95
added a commit
that referenced
this pull request
Nov 1, 2024
Specifically `rust-version = "1.58"` in the `autogen` module that I added in #223 is weird, since any developers working on and/or contributing to the repository should easily be able to run the latest stable and take advantage of newer Rust features in `autogen` code.
MarijnS95
added a commit
that referenced
this pull request
Dec 27, 2024
Specifically `rust-version = "1.58"` in the `autogen` module that I added in #223 is weird, since any developers working on and/or contributing to the repository should easily be able to run the latest stable and take advantage of newer Rust features in `autogen` code.
MarijnS95
added a commit
that referenced
this pull request
Dec 28, 2024
Specifically `rust-version = "1.58"` in the `autogen` module that I added in #223 is weird, since any developers working on and/or contributing to the repository should easily be able to run the latest stable and take advantage of newer Rust features in `autogen` code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.