This repository has been archived by the owner on Jun 18, 2021. It is now read-only.
Handle error case for SwapChain::get_next_texture #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Nov 6, 2019
| }, | ||
| swap_chain_id: &self.id, | ||
| if output.view_id == wgn::Id::ERROR { | ||
| Err(()) |
There was a problem hiding this comment.
we should follow up with a better error here
There was a problem hiding this comment.
Since we're treating a zero-valued Id as an error, I'm not sure how you'd distinguish between any different errors that might occur. I figured the doc comment snippet is good enough until there's a more specific error-reporting mechanism in wgpu-native.
bors bot
added a commit
that referenced
this pull request
Nov 6, 2019
115: Handle error case for SwapChain::get_next_texture r=kvark a=antonok-edm Updates `SwapChain::get_next_texture` to account for gfx-rs/wgpu#369. Otherwise, an invalid `Id` is returned and may cause confusing errors. Co-authored-by: Anton Lazarev <antonok35@gmail.com>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
SwapChain::get_next_textureto account for gfx-rs/wgpu#369. Otherwise, an invalidIdis returned and may cause confusing errors.