fix(dx12): map composite alpha mode #7117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
requested changes
Feb 12, 2025
wgpu-hal/src/dx12/adapter.rs
Outdated
Comment on lines
867
to
871
| wgt::CompositeAlphaMode::Auto, | ||
| wgt::CompositeAlphaMode::Inherit, | ||
| wgt::CompositeAlphaMode::Opaque, | ||
| wgt::CompositeAlphaMode::PostMultiplied, | ||
| wgt::CompositeAlphaMode::PreMultiplied, |
There was a problem hiding this comment.
This needs to be conditional on rendering to a DComp swapchain. Regular swapchains should only have Opaque
auto-merge was automatically disabled
February 12, 2025 22:50
Head branch was pushed to by a user without write access
|
apologies, had a missing |
vorporeal
pushed a commit
to warpdotdev/wgpu
that referenced
this pull request
Mar 3, 2025
* fix(dx12): map composite alpha mode closes gfx-rs#7108 * changelog entry * add composite modes based on surface target * fix missing `in` in change log entry
vorporeal
added a commit
to warpdotdev/wgpu
that referenced
this pull request
Mar 3, 2025
* fix(dx12): map composite alpha mode closes gfx-rs#7108 * changelog entry * add composite modes based on surface target * fix missing `in` in change log entry Co-authored-by: Amr Bashir <github@amrbashir.me>
davnotdev
pushed a commit
to davnotdev/wgpu
that referenced
this pull request
Mar 4, 2025
* fix(dx12): map composite alpha mode closes gfx-rs#7108 * changelog entry * add composite modes based on surface target * fix missing `in` in change log entry
sharmajai
pushed a commit
to sharmajai/wgpu
that referenced
this pull request
Oct 12, 2025
* fix(dx12): map composite alpha mode closes gfx-rs#7108 * changelog entry * add composite modes based on surface target * fix missing `in` in change log entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
closes #7108
Description
Describe what problem this is solving, and how it's solved.
Fix wgpu alpha modes when using it with windows DirectComposition.
Testing
Explain how this change is tested.
This PR was tested using the repro at https://github.com/microsoft/windows-rs/blob/91cfd289eeae05fa0bb6bdbe37a8426061f77c6e/crates/samples/windows/dcomp/src/main.rs
Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.