-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added server example themes support with two sample themes and a favicon. #6848
Conversation
Fixed whitespace |
Check actions cancelled for some other priority job and I can't seem to manually re-run them, so MOAR OPACITY
Trying to re-trigger the cancelled action.
This Actions pipeline is failing for random issues.
Ugh an issue with the build environment seems to be killing these Actions. ModuleNotFoundError: No module named 'distutils' |
I think an update to our Actions environment is actually blocking these. Anybody else hitting this error? |
@ggerganov did something change in testing automation? This PR is purely additive and shouldn't break anything else but automation keeps tripping on the same error as this python 3.12 support issue. |
I think you need to rebase on latest Btw, it seems the themes are copy-pasting the |
Good point I'll try rebasing.
I thought about symlinks for unchanged files but then there is the opposite problem. Changing one theme affects and/or breaks the other themes. I thought these were copied examples. What would you propose? This is simple just using the |
@ggerganov any bump on this? Since the UI is effectively rendered completely using the contents of the public folder it makes sense to me to change copies for themes and just use |
Let's give this a try, but first remove the following files from the themes:
Since these are unchanged, they will be served from the static contents embedded in the llama.cpp/examples/server/server.cpp Lines 3729 to 3735 in 947d3ad
Also rename all files that have underscore to use a dash for consistency |
I see. I thought the path dir was all or nothing but yes that makes sense. OK let me clean it up a bit. |
This will be served from the static string built-in to server.
This will be served from the static string built-in to server.
This will be served from the static string built-in to server.
This will be served from the static string built-in to server.
This will be served from the static string built-in to server.
This will be served from the static string built-in to server.
Sloppy commits but done. Thanks @ggerganov |
How are folks gonna customize browser presentation code buried in the C++ binary? Or is the point to hinder that? Every tweak to the UI will require a make to compile reload and test, defeating the utility & practicality of externalized user interface code. |
By separating the UI elements ( |
Thanks for the clarification. I will pull the change and give it a try. |
I've always thought the
--path
flag could be used to support basic UI themes and also thought it should have a favicon. I've added these and tested them out. Have a look.