Skip to content

[SYCL] fix the mul_mat_id ut issues #8427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2024
Merged

[SYCL] fix the mul_mat_id ut issues #8427

merged 2 commits into from
Jul 12, 2024

Conversation

@ClarkChin08
Copy link
Contributor

@ClarkChin08 ClarkChin08 commented Jul 11, 2024 •
edited by airMeng
Loading

airMeng and others added 2 commits July 11, 2024 03:08
@airMeng
fix part of mul_mat_id
90c8470
skip the bfloat 16 sycl ut
c374705 
Signed-off-by: Chen Xi <xi2chen@intel.com>
@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Jul 11, 2024
@airMeng airMeng mentioned this pull request Jul 11, 2024
Closed
4 tasks
@airMeng airMeng changed the title [sycl] fix the mul_mat_id ut issues [SYCL] fix the mul_mat_id ut issues Jul 11, 2024
NeoZhangJianyu
NeoZhangJianyu approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@NeoZhangJianyu NeoZhangJianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run UT on iGPU.
Only two cases are fault as same as base.
It's good result!

MUL_MAT(type_a=iq4_nl,type_b=f32,m=16,n=1,k=256,bs=[1,1],nr=[1,1]): [MUL_MAT] NMSE = 0.183367694 > 0.000500000 FAIL
MUL_MAT_ID(type_a=iq4_nl,type_b=f32,n_mats=4,n_used=2,b=0,m=512,n=1,k=256): [MUL_MAT_ID] NMSE = 0.284035424 > 0.000500000 FAIL

@NeoZhangJianyu NeoZhangJianyu merged commit b549a1b into ggml-org:master Jul 12, 2024
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 13, 2024
@ClarkChin08 @airMeng
[SYCL] fix the mul_mat_id ut issues (ggml-org#8427)
fa700d1 
* fix part of mul_mat_id

* skip the bfloat 16 sycl ut

Signed-off-by: Chen Xi <xi2chen@intel.com>

---------

Signed-off-by: Chen Xi <xi2chen@intel.com>
Co-authored-by: Meng, Hengyu <hengyu.meng@intel.com>
Co-authored-by: Chen Xi <xi2chen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slaren slaren slaren approved these changes

@NeoZhangJianyu NeoZhangJianyu NeoZhangJianyu approved these changes

Assignees

No one assigned

Labels

ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ClarkChin08 @slaren @NeoZhangJianyu @airMeng