Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save loss vector when #15

Closed
ctroupin opened this issue Sep 18, 2023 · 0 comments · Fixed by #18
Closed

Save loss vector when #15

ctroupin opened this issue Sep 18, 2023 · 0 comments · Fixed by #18
Assignees
@ctroupin
Labels
enhancement New feature or request

Comments

@ctroupin
Copy link
Member

I see that the function reconstruct ends up by writing the loss in the netCDF file (see https://github.com/gher-uliege/DINCAE.jl/blob/main/src/model.jl#L817-L822, while reconstruct_points doesn't.

Is there a reason for that, and if not shall it be added?
@ctroupin ctroupin added the enhancement New feature or request label Sep 18, 2023
@ctroupin ctroupin self-assigned this Sep 18, 2023
@ctroupin ctroupin linked a pull request Oct 5, 2023 that will close this issue
Writing loss and parameters in function reconstruct_points #18
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctroupin ctroupin

Labels
enhancement New feature or request
Projects
CPR-DINCAE
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Writing loss and parameters in function reconstruct_points gher-uliege/DINCAE.jl
1 participant
@ctroupin