From 786bf81629733219d6675aac4ff779298d3244f5 Mon Sep 17 00:00:00 2001 From: Martin Sievers Date: Tue, 14 Nov 2023 22:37:07 +0100 Subject: [PATCH 1/6] Add \vfill to definition of \footnoterule to keep footnotes at the bottom --- lni.cls | 2 +- lni.dtx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lni.cls b/lni.cls index f07b44a..60b731b 100644 --- a/lni.cls +++ b/lni.cls @@ -481,7 +481,7 @@ \RequirePackage{verbatim} \def\verbatim@processline{\hskip0.5cm\the\verbatim@line\par} \renewcommand\footnoterule{% - \kern-3\p@ + \vfill\kern-3\p@ \hrule\@width 5cm \kern2.6\p@} \newdimen\fnindent diff --git a/lni.dtx b/lni.dtx index 62618e1..3c959bb 100644 --- a/lni.dtx +++ b/lni.dtx @@ -1352,7 +1352,7 @@ This work consists of the file lni.dtx % Set rule width und correct size % \begin{macrocode} \renewcommand\footnoterule{% - \kern-3\p@ + \vfill\kern-3\p@ \hrule\@width 5cm \kern2.6\p@} \newdimen\fnindent From 89109167c604b50d4a9e99be4145e89db91cfafd Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Wed, 15 Nov 2023 11:01:27 +0100 Subject: [PATCH 2/6] Add CHANGELOG.md linter (#128) --- .github/workflows/check.yml | 12 ++++++++++++ CHANGELOG.md | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 2d41f50..b52a923 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -89,3 +89,15 @@ jobs: with: name: CTAN-${{ matrix.engine }} path: '*.tar.gz' + changelog: + name: CHANGELOG.md + runs-on: ubuntu-latest + steps: + - name: Check out code + uses: actions/checkout@v4 + with: + show-progress: '' + - uses: jbangdev/jbang-action@v0.110.1 + with: + script: com.github.nbbrd.heylogs:heylogs-cli:0.7.2:bin + scriptargs: "check CHANGELOG.md" diff --git a/CHANGELOG.md b/CHANGELOG.md index 26455ae..1534e6e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,7 @@ # Changelog All notable changes to this project will be documented in this file. -The format is based on [Keep a Changelog](http://keepachangelog.com/). +The format is based on [Keep a Changelog](https://keepachangelog.com/). ## [Unreleased] @@ -97,7 +97,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/). ### Added -- New option `nofonts` to use the class file on older systems ([#53](https://github.com/gi-ev/LNI/issues/52)) +- New option `nofonts` to use the class file on older systems ([#53](https://github.com/gi-ev/LNI/issues/53)) ### Changed From 00da7b67eb4b0e9e2a396244f9bc3fbb2ebc824a Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Wed, 15 Nov 2023 11:10:01 +0100 Subject: [PATCH 3/6] Add \pdfoutput=1 (#126) --- .gitignore | 4 ++-- CHANGELOG.md | 1 + lni-author-template.tex | 12 ++++++++---- lni-paper-example-de.tex | 3 +++ lni.dtx | 17 +++++++++++++---- 5 files changed, 27 insertions(+), 10 deletions(-) diff --git a/.gitignore b/.gitignore index e365d6b..cd09f45 100644 --- a/.gitignore +++ b/.gitignore @@ -1,6 +1,6 @@ lni.pdf -lni-author-template.pdf -lni-paper-example-de.pdf +lni-author-template*.pdf +lni-paper-example-*.pdf mybibfile.bib diff --git a/CHANGELOG.md b/CHANGELOG.md index 1534e6e..52f9717 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/). ### Added - Added option `anonymous` for anonymizing an article. [#100](https://github.com/gi-ev/LNI/pull/100) +- Added `\pdfoutput=1` to fix compatibility with [arXiv](https://arxiv.org/). [#81](https://github.com/gi-ev/LNI/issues/81) ### Changed diff --git a/lni-author-template.tex b/lni-author-template.tex index 3e9bb4a..0d9269a 100644 --- a/lni-author-template.tex +++ b/lni-author-template.tex @@ -2,14 +2,18 @@ % !TeX program = pdflatex % !BIB program = bibtex -%%% Um einen Artikel auf deutsch zu schreiben, genügt es die Klasse ohne -%%% Parameter zu laden. -%%% Zur Anonymisierung kann die ``anonymous'' Option genutzt werden. -\documentclass[]{lni} +\RequirePackage{iftex}\ifluatex\else +\pdfoutput=1 +\fi %%% To write an article in English, please use the option ``english'' in order %%% to get the correct hyphenation patterns and terms. %%% \documentclass[english]{class} %%% for anonymizing an article you can use the ``anonymous'' option. +%%% +%%% Um einen Artikel auf deutsch zu schreiben, genügt es die Klasse ohne +%%% Parameter zu laden. +%%% Zur Anonymisierung kann die ``anonymous'' Option genutzt werden. +\documentclass[]{lni} %% \begin{document} %%% Mehrere Autoren werden durch \and voneinander getrennt. diff --git a/lni-paper-example-de.tex b/lni-paper-example-de.tex index 6e3452d..fb7118a 100644 --- a/lni-paper-example-de.tex +++ b/lni-paper-example-de.tex @@ -1,6 +1,9 @@ % !TeX encoding = UTF-8 % !TeX spellcheck = de_DE +\RequirePackage{iftex}\ifluatex\else +\pdfoutput=1 +\fi %% Dies gibt Warnungen aus, sollten veraltete LaTeX-Befehle verwendet werden \RequirePackage[l2tabu, orthodox]{nag} diff --git a/lni.dtx b/lni.dtx index e60656a..e6e2deb 100644 --- a/lni.dtx +++ b/lni.dtx @@ -3002,14 +3002,19 @@ EXECUTE {end.bib} % % !TeX program = pdflatex % % !BIB program = biber % % !TeX spellcheck = de-DE -%%% Um einen Artikel auf deutsch zu schreiben, genügt es die Klasse ohne -%%% Parameter zu laden. -%%% Zur Anonymisierung kann die ``anonymous'' Option genutzt werden. -\documentclass[]{lni} +% Needs to be written in the first 5 lines, because of arXiv's requirements +\RequirePackage{iftex}\ifluatex\else +\pdfoutput=1 +\fi %%% To write an article in English, please use the option ``english'' in order %%% to get the correct hyphenation patterns and terms. %%% \documentclass[english]{class} %%% for anonymizing an article you can use the ``anonymous'' option. +%%% +%%% Um einen Artikel auf deutsch zu schreiben, genügt es die Klasse ohne +%%% Parameter zu laden. +%%% Zur Anonymisierung kann die ``anonymous'' Option genutzt werden. +\documentclass[]{lni} %% \begin{document} %%% Mehrere Autoren werden durch \and voneinander getrennt. @@ -3146,6 +3151,10 @@ Schlagwort1 \and Schlagwort2 %Keyword1 \and Keyword2 % % !TeX program = pdflatex % % !BIB program = biber % % !TeX spellcheck = de-DE +% Needs to be written in the first 5 lines, because of arXiv's requirements +\RequirePackage{iftex}\ifluatex\else +\pdfoutput=1 +\fi %% Dies gibt Warnungen aus, sollten veraltete LaTeX-Befehle verwendet werden \RequirePackage[l2tabu, orthodox]{nag} From bfc2b74ad0a0ceeaa17856951ae7181fa7fd60d0 Mon Sep 17 00:00:00 2001 From: Oliver Kopp Date: Wed, 15 Nov 2023 11:40:30 +0100 Subject: [PATCH 4/6] Fix CHANGELOG.md consistency (#130) --- CHANGELOG.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 52f9717..a54899c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,22 +7,23 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/). ### Added -- Added option `anonymous` for anonymizing an article. [#100](https://github.com/gi-ev/LNI/pull/100) -- Added `\pdfoutput=1` to fix compatibility with [arXiv](https://arxiv.org/). [#81](https://github.com/gi-ev/LNI/issues/81) +- Added option `anonymous` for anonymizing an article ([#100](https://github.com/gi-ev/LNI/pull/100)) +- Added `\pdfoutput=1` to fix compatibility with [arXiv](https://arxiv.org/) ([#81](https://github.com/gi-ev/LNI/issues/81)) ### Changed -- Improve spacing in and around lists to better match the Word template. [#102](https://github.com/gi-ev/LNI/pull/102) -- Synced title spacing with Word template. [#104](https://github.com/gi-ev/LNI/pull/104) +- Improve spacing in and around lists to better match the Word template ([#102](https://github.com/gi-ev/LNI/pull/102)) +- Synced title spacing with Word template ([#104](https://github.com/gi-ev/LNI/pull/104)) - (chore) `build.sh` assumes `*.md` are formatted using LF line endings, removed `dos2unix` dependency. - Add more links to `biblatex-lni` to documentation ([#90](https://github.com/gi-ev/LNI/issues/90)) - Add `\yearofpublication` to documentation ([#89](https://github.com/gi-ev/LNI/pull/89)) -- Improvement for documentation (merge requests [#89](https://github.com/gi-ev/LNI/issues/89),[#90](https://github.com/gi-ev/LNI/issues/90), [#93](https://github.com/gi-ev/LNI/issues/93), [#95](https://github.com/gi-ev/LNI/issues/95), [#96](https://github.com/gi-ev/LNI/issues/96) +- Improvement for documentation ([#89](https://github.com/gi-ev/LNI/issues/89), [#90](https://github.com/gi-ev/LNI/issues/90), [#93](https://github.com/gi-ev/LNI/issues/93), [#95](https://github.com/gi-ev/LNI/issues/95), [#96](https://github.com/gi-ev/LNI/issues/96)) ### Fixed - hyperref option `linktoc` fixed to `all` instead of `both` - Fixed output in bst files ([#97](https://github.com/gi-ev/LNI/issues/97)) +- Hyperlinked bibliographic entries work again ([#107](https://github.com/gi-ev/LNI/issues/107)) ## [1.7] - 2021-03-02 From 91f97513f3a5485708059bb1582b77d18b5ae854 Mon Sep 17 00:00:00 2001 From: Martin Sievers Date: Wed, 15 Nov 2023 23:04:23 +0100 Subject: [PATCH 5/6] Fix #87: Suppress \footnote from pdf bookmarks --- lni.cls | 8 +++++++- lni.dtx | 10 +++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/lni.cls b/lni.cls index 94d5a0d..cfffdcf 100644 --- a/lni.cls +++ b/lni.cls @@ -264,6 +264,7 @@ {\multicitedelim}% {\usebibmacro{postnote}}% \fi% +\RequirePackage{etoolbox} \RequirePackage{graphicx} \RequirePackage{eso-pic} \RequirePackage{grffile} @@ -300,7 +301,8 @@ \par}% \fi} \renewcommand{\title}{\@dblarg\@@title} -\def\@@title[#1]#2{\gdef\@shorttitle{#1}\gdef\@title{#2}} +\def\@@title[#1]#2{% + \gdef\@shorttitle{#1}\gdef\@title{#2}} \newcommand{\subtitle}[1]{\gdef\@subtitle{#1}} \renewcommand{\author}{\@dblarg\@@author} \newcommand{\@@author}[2][]{% @@ -480,6 +482,7 @@ \setlength{\mathindent}{0.5cm} \RequirePackage{verbatim} \def\verbatim@processline{\hskip0.5cm\the\verbatim@line\par} +\robustify{\footnote} \renewcommand\footnoterule{% \vfill\kern-3\p@ \hrule\@width 5cm @@ -569,6 +572,9 @@ allcolors=black,% pdfstartview=Fit,% }% + \pdfstringdefDisableCommands{% + \def\footnote#1{}% + } }% \DeclareHookRule{env/document/begin}{cid/loadhyp}{before}{biblatex} \else diff --git a/lni.dtx b/lni.dtx index dcd66f0..b556875 100644 --- a/lni.dtx +++ b/lni.dtx @@ -1062,6 +1062,7 @@ This work consists of the file lni.dtx \fi% % \end{macrocode} % \begin{macrocode} +\RequirePackage{etoolbox} \RequirePackage{graphicx} \RequirePackage{eso-pic} \RequirePackage{grffile} @@ -1115,7 +1116,8 @@ This work consists of the file lni.dtx % \begin{macro}{\title} % \begin{macrocode} \renewcommand{\title}{\@dblarg\@@title} -\def\@@title[#1]#2{\gdef\@shorttitle{#1}\gdef\@title{#2}} +\def\@@title[#1]#2{% + \gdef\@shorttitle{#1}\gdef\@title{#2}} % \end{macrocode} % \end{macro} % \begin{macro}{\subtitle} @@ -1349,6 +1351,9 @@ This work consists of the file lni.dtx \RequirePackage{verbatim} \def\verbatim@processline{\hskip0.5cm\the\verbatim@line\par} % \end{macrocode} +% \begin{macrocode} +\robustify{\footnote} +% \end{macrocode} % Set rule width und correct size % \begin{macrocode} \renewcommand\footnoterule{% @@ -1484,6 +1489,9 @@ This work consists of the file lni.dtx allcolors=black,% pdfstartview=Fit,% }% + \pdfstringdefDisableCommands{% + \def\footnote#1{}% + } }% \DeclareHookRule{env/document/begin}{cid/loadhyp}{before}{biblatex} \else From a82139c78e03e0a66f9090f84503eecc02d744ed Mon Sep 17 00:00:00 2001 From: Martin Sievers Date: Wed, 15 Nov 2023 23:09:46 +0100 Subject: [PATCH 6/6] Update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a54899c..1d2df42 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/). - hyperref option `linktoc` fixed to `all` instead of `both` - Fixed output in bst files ([#97](https://github.com/gi-ev/LNI/issues/97)) - Hyperlinked bibliographic entries work again ([#107](https://github.com/gi-ev/LNI/issues/107)) +- `\footnote` is not used for pdf bookmarks ([#87](https://github.com/gi-ev/LNI/issues/87)) +- Footnotes are always set at the bottom of the page ([#122](https://github.com/gi-ev/LNI/issues/122)) ## [1.7] - 2021-03-02