From 678e5ac0416a7d3386205d58cdf03ede67727e42 Mon Sep 17 00:00:00 2001 From: Alexander Kachkaev Date: Sat, 5 Nov 2022 14:18:42 +0000 Subject: [PATCH 1/5] Improve dev setup --- .eslintignore | 31 ++++++++++++++++++++++--------- .eslintrc.js | 2 ++ .github/workflows/ci.yml | 2 +- .gitignore | 5 ++--- .markdownlintignore | 29 ++++++++++++++++++++--------- .prettierignore | 31 ++++++++++++++++++++++--------- jest.config.js | 11 ----------- jest.config.mjs | 7 +++++++ package.json | 11 +++++------ tsconfig.json | 1 + yarn.lock | 22 +--------------------- 11 files changed, 83 insertions(+), 69 deletions(-) delete mode 100644 jest.config.js create mode 100644 jest.config.mjs diff --git a/.eslintignore b/.eslintignore index 31617b8..faffd8e 100644 --- a/.eslintignore +++ b/.eslintignore @@ -1,18 +1,31 @@ -## extensions -*.* -LICENSE +##################### +## Specific to ESLint +##################### + +## Ignore all files (but still allow sub-folder scanning) +* +!*/ + +## Allow certain file types +!*.cjs !*.js !*.json +!*.mjs !*.ts -!/.github/ -/fixtures/ +######################### +## Shared between linters +######################### + +fixtures + +######################## +## Same as in .gitignore +######################## -## same as in .gitignore -node_modules -*.log .DS_Store +*.log cache coverage dist -junit.xml +node_modules diff --git a/.eslintrc.js b/.eslintrc.js index 91a5bc7..03e2ce9 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -1,5 +1,7 @@ +/** @type{import("eslint").Linter.Config} */ module.exports = { extends: ["@kachkaev/eslint-config-base"], + reportUnusedDisableDirectives: true, rules: { /* eslint-disable @typescript-eslint/naming-convention */ "unicorn/prefer-json-parse-buffer": "off", diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 13e4a40..62f21b2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -101,4 +101,4 @@ jobs: uses: codecov/codecov-action@v3 if: matrix.os == 'ubuntu-22.04' && matrix.node == 18 with: - files: ./coverage/cobertura-coverage.xml + files: coverage/lcov.info diff --git a/.gitignore b/.gitignore index b49bc63..ee28a1b 100644 --- a/.gitignore +++ b/.gitignore @@ -1,7 +1,6 @@ -node_modules -*.log .DS_Store +*.log cache coverage dist -junit.xml +node_modules diff --git a/.markdownlintignore b/.markdownlintignore index 208e30e..f85f403 100644 --- a/.markdownlintignore +++ b/.markdownlintignore @@ -1,16 +1,27 @@ -## extensions -*.* -LICENSE +########################### +## Specific to Markdownlint +########################### + +## Ignore all files (but still allow sub-folder scanning) +* +!*/ + +## Allow certain file types !*.md -!/.github/ -/fixtures/ +######################### +## Shared between linters +######################### + +fixtures + +######################## +## Same as in .gitignore +######################## -## same as in .gitignore -node_modules -*.log .DS_Store +*.log cache coverage dist -junit.xml +node_modules diff --git a/.prettierignore b/.prettierignore index 6e20f33..9138730 100644 --- a/.prettierignore +++ b/.prettierignore @@ -1,20 +1,33 @@ -## extensions -*.* -LICENSE +####################### +## Specific to Prettier +####################### + +## Ignore all files (but still allow sub-folder scanning) +* +!*/ + +## Allow certain file types +!*.cjs !*.js !*.json !*.md +!*.mjs !*.ts !*.yml -!/.github/ -/fixtures/ +######################### +## Shared between linters +######################### + +fixtures + +######################## +## Same as in .gitignore +######################## -## same as in .gitignore -node_modules -*.log .DS_Store +*.log cache coverage dist -junit.xml +node_modules diff --git a/jest.config.js b/jest.config.js deleted file mode 100644 index d103bcc..0000000 --- a/jest.config.js +++ /dev/null @@ -1,11 +0,0 @@ -const testResultsAndCoverage = !!process.env.REPORT_TEST_RESULTS_AND_COVERAGE; - -module.exports = { - collectCoverage: testResultsAndCoverage, - collectCoverageFrom: ["dist/**/*.js", "!dist/**/*.test.js"], - coverageReporters: ["cobertura", "html", "text"], - reporters: testResultsAndCoverage - ? ["default", ["jest-junit", { suiteNameTemplate: "{filepath}" }]] - : ["default"], - testRegex: ".test.js$", -}; diff --git a/jest.config.mjs b/jest.config.mjs new file mode 100644 index 0000000..bc6d7e8 --- /dev/null +++ b/jest.config.mjs @@ -0,0 +1,7 @@ +/* eslint-disable import/no-anonymous-default-export */ +/** @type {import("jest").Config} */ +export default { + collectCoverage: !!process.env.TEST_COVERAGE, + collectCoverageFrom: ["dist/**/*.js", "!dist/**/*.test.js"], + testRegex: ".test.js$", +}; diff --git a/package.json b/package.json index 0f65d19..87918f0 100644 --- a/package.json +++ b/package.json @@ -17,22 +17,22 @@ "build": "tsc --project .", "clean": "rimraf cache coverage dist", "fix": "npm-run-all --continue-on-error fix:*", - "fix:eslint": "eslint --fix \"**/*\"", - "fix:markdownlint": "markdownlint --fix \"**/*\"", + "fix:eslint": "eslint --fix .", + "fix:markdownlint": "markdownlint --fix .", "fix:prettier": "prettier --write .", "fix:yarn-deduplicate": "yarn install && yarn-deduplicate --strategy=fewer && yarn install", "lint": "npm-run-all --continue-on-error lint:*", - "lint:markdownlint": "markdownlint \"**/*\"", + "lint:markdownlint": "markdownlint .", "lint:prettier": "prettier --check .", "lint:tsc": "tsc --project .", - "lint:eslint": "eslint \"**/*\" --report-unused-disable-directives", + "lint:eslint": "eslint . --report-unused-disable-directives", "lint:yarn-deduplicate": "yarn-deduplicate --fail --list --strategy=fewer", "prepare": "husky install", "prepublishOnly": "yarn lint && yarn test", "test": "yarn clean && yarn build && jest" }, "lint-staged": { - "**/*": [ + "**": [ "markdownlint --fix", "prettier --write" ] @@ -55,7 +55,6 @@ "eslint": "^8.26.0", "husky": "^8.0.1", "jest": "^29.2.2", - "jest-junit": "^14.0.1", "lint-staged": "^13.0.3", "markdownlint-cli": "^0.32.2", "npm-run-all": "^4.1.5", diff --git a/tsconfig.json b/tsconfig.json index 48a0f6f..0e6db69 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -4,6 +4,7 @@ "inlineSourceMap": true, "lib": ["ES2019"], "module": "commonjs", + "checkJs": true, "outDir": "dist", "rootDir": "src", "strict": true, diff --git a/yarn.lock b/yarn.lock index d524910..02bedf7 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2606,16 +2606,6 @@ jest-haste-map@^29.2.1: optionalDependencies: fsevents "^2.3.2" -jest-junit@^14.0.1: - version "14.0.1" - resolved "https://registry.yarnpkg.com/jest-junit/-/jest-junit-14.0.1.tgz#5b357d6f5d333459585d628a24cd48b5bbc92ba2" - integrity sha512-h7/wwzPbllgpQhhVcRzRC76/cc89GlazThoV1fDxcALkf26IIlRsu/AcTG64f4nR2WPE3Cbd+i/sVf+NCUHrWQ== - dependencies: - mkdirp "^1.0.4" - strip-ansi "^6.0.1" - uuid "^8.3.2" - xml "^1.0.1" - jest-leak-detector@^29.2.1: version "29.2.1" resolved "https://registry.yarnpkg.com/jest-leak-detector/-/jest-leak-detector-29.2.1.tgz#ec551686b7d512ec875616c2c3534298b1ffe2fc" @@ -3194,7 +3184,7 @@ mkdirp@^0.5.1: dependencies: minimist "^1.2.6" -mkdirp@^1.0.3, mkdirp@^1.0.4: +mkdirp@^1.0.3: version "1.0.4" resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-1.0.4.tgz#3eb5ed62622756d79a5f0e2a221dfebad75c2f7e" integrity sha512-vVqVZQyf3WLx2Shd0qJ9xuvqgAyKPLAiqITEtqW0oIUjzo3PePDd6fW9iFz30ef7Ysp/oiWqbhszeGWW2T6Gzw== @@ -4253,11 +4243,6 @@ uuid@^3.3.2: resolved "https://registry.yarnpkg.com/uuid/-/uuid-3.4.0.tgz#b23e4358afa8a202fe7a100af1f5f883f02007ee" integrity sha512-HjSDRw6gZE5JMggctHBcjVak08+KEVhSIiDzFnT9S9aegmp85S/bReBVTb4QTFaRNptJ9kuYaNhnbNEOkbKb/A== -uuid@^8.3.2: - version "8.3.2" - resolved "https://registry.yarnpkg.com/uuid/-/uuid-8.3.2.tgz#80d5b5ced271bb9af6c445f21a1a04c606cefbe2" - integrity sha512-+NYs2QeMWy+GWFOEm9xnn6HCDp0l7QBD7ml8zLUmJ+93Q5NF0NocErnwkTkXVFNiX3/fpC6afS8Dhb/gz7R7eg== - v8-to-istanbul@^9.0.1: version "9.0.1" resolved "https://registry.yarnpkg.com/v8-to-istanbul/-/v8-to-istanbul-9.0.1.tgz#b6f994b0b5d4ef255e17a0d17dc444a9f5132fa4" @@ -4383,11 +4368,6 @@ write-file-atomic@^4.0.1: imurmurhash "^0.1.4" signal-exit "^3.0.7" -xml@^1.0.1: - version "1.0.1" - resolved "https://registry.yarnpkg.com/xml/-/xml-1.0.1.tgz#78ba72020029c5bc87b8a81a3cfcd74b4a2fc1e5" - integrity sha512-huCv9IH9Tcf95zuYCsQraZtWnJvBtLVE0QHMOs8bWyZAFZNDcYjsPq1nEx8jKA9y+Beo9v+7OBPRisQTjinQMw== - y18n@^5.0.5: version "5.0.8" resolved "https://registry.yarnpkg.com/y18n/-/y18n-5.0.8.tgz#7f4934d0f7ca8c56f95314939ddcd2dd91ce1d55" From 92438db30a02dda52889d3c5e50d63f313601216 Mon Sep 17 00:00:00 2001 From: Alexander Kachkaev Date: Sat, 5 Nov 2022 14:21:52 +0000 Subject: [PATCH 2/5] Fix env var name --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 62f21b2..607a017 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,7 +95,7 @@ jobs: - name: Run unit tests run: yarn test env: - REPORT_TEST_RESULTS_AND_COVERAGE: ${{ matrix.os == 'ubuntu-22.04' && matrix.node == 18 }} + TEST_COVERAGE: ${{ matrix.os == 'ubuntu-22.04' && matrix.node == 18 }} - name: Report code coverage to codecov.io uses: codecov/codecov-action@v3 From bfc738efaaa696d4b44095c63691baa936eb4ce4 Mon Sep 17 00:00:00 2001 From: Alexander Kachkaev Date: Sat, 5 Nov 2022 14:27:10 +0000 Subject: [PATCH 3/5] Cleanup scripts --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 87918f0..b0a1173 100644 --- a/package.json +++ b/package.json @@ -14,7 +14,7 @@ "license": "BSD-3-Clause", "main": "dist", "scripts": { - "build": "tsc --project .", + "build": "tsc", "clean": "rimraf cache coverage dist", "fix": "npm-run-all --continue-on-error fix:*", "fix:eslint": "eslint --fix .", @@ -24,8 +24,8 @@ "lint": "npm-run-all --continue-on-error lint:*", "lint:markdownlint": "markdownlint .", "lint:prettier": "prettier --check .", - "lint:tsc": "tsc --project .", - "lint:eslint": "eslint . --report-unused-disable-directives", + "lint:tsc": "tsc --noEmit", + "lint:eslint": "eslint .", "lint:yarn-deduplicate": "yarn-deduplicate --fail --list --strategy=fewer", "prepare": "husky install", "prepublishOnly": "yarn lint && yarn test", From f8dc92fbba79dacc3f4edc36ca86a417f8da6055 Mon Sep 17 00:00:00 2001 From: Alexander Kachkaev Date: Sat, 5 Nov 2022 15:40:14 +0000 Subject: [PATCH 4/5] Update linting configs --- .eslintrc.js | 5 ++- .markdownlint.json | 4 +-- package.json | 6 ++-- src/printer.ts | 3 +- yarn.lock | 87 +++++++++++++++++++++------------------------- 5 files changed, 48 insertions(+), 57 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 03e2ce9..4909731 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -4,9 +4,8 @@ module.exports = { reportUnusedDisableDirectives: true, rules: { /* eslint-disable @typescript-eslint/naming-convention */ - "unicorn/prefer-json-parse-buffer": "off", - "unicorn/prefer-module": "off", - "unicorn/prefer-node-protocol": "off", + "unicorn/prefer-module": "off", // Can be enabled after switching to ESM or Node.js >=16 + "unicorn/prefer-node-protocol": "off", // Can be enabled after switching to ESM or Node.js >=16 /* eslint-enable @typescript-eslint/naming-convention */ }, }; diff --git a/.markdownlint.json b/.markdownlint.json index 2254675..4384acb 100644 --- a/.markdownlint.json +++ b/.markdownlint.json @@ -1,5 +1,3 @@ { - "extends": "./node_modules/@kachkaev/markdownlint-config/index.json", - "first-line-heading": false, - "no-inline-html": false + "extends": "@kachkaev/markdownlint-config" } diff --git a/package.json b/package.json index b0a1173..e64ab93 100644 --- a/package.json +++ b/package.json @@ -25,7 +25,7 @@ "lint:markdownlint": "markdownlint .", "lint:prettier": "prettier --check .", "lint:tsc": "tsc --noEmit", - "lint:eslint": "eslint .", + "lint:eslint": "eslint --report-unused-disable-directives .", "lint:yarn-deduplicate": "yarn-deduplicate --fail --list --strategy=fewer", "prepare": "husky install", "prepublishOnly": "yarn lint && yarn test", @@ -46,8 +46,8 @@ "temp-dir": "^2.0.0" }, "devDependencies": { - "@kachkaev/eslint-config-base": "^0.4.3", - "@kachkaev/markdownlint-config": "^0.3.0", + "@kachkaev/eslint-config-base": "^0.5.0", + "@kachkaev/markdownlint-config": "^0.5.0", "@types/jest": "^29.2.2", "@types/object-hash": "^2.2.1", "@types/prettier": "^2.7.1", diff --git a/src/printer.ts b/src/printer.ts index bbcf956..54a1f12 100644 --- a/src/printer.ts +++ b/src/printer.ts @@ -9,7 +9,7 @@ export const print = (path: AstPath) => { } /* istanbul ignore next */ - default: + default: { if (process.env.NODE_ENV === "test") { throw new Error( `Unknown Elm node: ${JSON.stringify( @@ -23,5 +23,6 @@ export const print = (path: AstPath) => { console.error("Unknown Elm node:", node); return node.source; + } } }; diff --git a/yarn.lock b/yarn.lock index 02bedf7..8206d2b 100644 --- a/yarn.lock +++ b/yarn.lock @@ -127,7 +127,7 @@ resolved "https://registry.yarnpkg.com/@babel/helper-string-parser/-/helper-string-parser-7.19.4.tgz#38d3acb654b4701a9b77fb0615a96f775c3a9e63" integrity sha512-nHtDoQcuqFmwYNYPz3Rah5ph2p8PFeFCsZk9A/48dPc/rGocJ5J3hAAZ7pb76VWX3fZKu+uEr/FhH5jLx7umrw== -"@babel/helper-validator-identifier@^7.15.7", "@babel/helper-validator-identifier@^7.18.6", "@babel/helper-validator-identifier@^7.19.1": +"@babel/helper-validator-identifier@^7.18.6", "@babel/helper-validator-identifier@^7.19.1": version "7.19.1" resolved "https://registry.yarnpkg.com/@babel/helper-validator-identifier/-/helper-validator-identifier-7.19.1.tgz#7eea834cf32901ffdc1a7ee555e2f9c27e249ca2" integrity sha512-awrNfaMtnHUr653GgGEs++LlAvW6w+DcPrOliSMXWCKo597CwL5Acf/wWdNkf/tfEQE3mjkeD1YOVZOUV/od1w== @@ -579,24 +579,24 @@ "@jridgewell/resolve-uri" "3.1.0" "@jridgewell/sourcemap-codec" "1.4.14" -"@kachkaev/eslint-config-base@^0.4.3": - version "0.4.3" - resolved "https://registry.yarnpkg.com/@kachkaev/eslint-config-base/-/eslint-config-base-0.4.3.tgz#8a6a0114165840626a3b927c744a9d84c0f73bc6" - integrity sha512-GggRs8G0l7soO9exX+ppfYuW0FjpjwJWK4xq0a3ZKS3RdNyN6UoKkt6Q46102spYA3yomZ2Ise1+odfl4eaQDQ== +"@kachkaev/eslint-config-base@^0.5.0": + version "0.5.0" + resolved "https://registry.yarnpkg.com/@kachkaev/eslint-config-base/-/eslint-config-base-0.5.0.tgz#aa044239708565ab7fd4fd0cf86001b4ab7a90ca" + integrity sha512-PbX1tOJrM1yF0SxXrajYvQJTvdTfyBVHB/LAe9QFXtw7UG56acYNKKu64HRr8eWQ2STSjFFH9ZG5g0LtNe89xQ== dependencies: - "@typescript-eslint/eslint-plugin" "^5.8.1" - "@typescript-eslint/parser" "^5.8.1" - eslint-config-prettier "^8.3.0" - eslint-plugin-import "^2.25.3" - eslint-plugin-jest "^25.3.3" + "@typescript-eslint/eslint-plugin" "^5.42.0" + "@typescript-eslint/parser" "^5.42.0" + eslint-config-prettier "^8.5.0" + eslint-plugin-import "^2.26.0" + eslint-plugin-jest "^27.1.4" eslint-plugin-json "^3.1.0" - eslint-plugin-simple-import-sort "^7.0.0" - eslint-plugin-unicorn "^40.0.0" + eslint-plugin-simple-import-sort "^8.0.0" + eslint-plugin-unicorn "^44.0.2" -"@kachkaev/markdownlint-config@^0.3.0": - version "0.3.0" - resolved "https://registry.yarnpkg.com/@kachkaev/markdownlint-config/-/markdownlint-config-0.3.0.tgz#5207232e65f18c16747bdb5e543054e1e01c9fe1" - integrity sha512-3+PtVFKPOojBlqdWOTf2GYC3y3+IP+FylBRYlErmnC6cm2uacr88pOuStGFfLPFXJIdqkAhdcUuo9XKruxil5A== +"@kachkaev/markdownlint-config@^0.5.0": + version "0.5.0" + resolved "https://registry.yarnpkg.com/@kachkaev/markdownlint-config/-/markdownlint-config-0.5.0.tgz#8b53247084936a3e90b102427f59a3fa5a78199b" + integrity sha512-b1wPLTSQ2OtjEp9loN8g3qeEsN94JhIX+36sqWlxBsSv3PgZDObht8bmMnZcPYR7x5RAQudrEklh46S7vMTTkg== "@nodelib/fs.scandir@2.1.5": version "2.1.5" @@ -778,7 +778,7 @@ dependencies: "@types/yargs-parser" "*" -"@typescript-eslint/eslint-plugin@^5.8.1": +"@typescript-eslint/eslint-plugin@^5.42.0": version "5.42.0" resolved "https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-5.42.0.tgz#36a8c0c379870127059889a9cc7e05c260d2aaa5" integrity sha512-5TJh2AgL6+wpL8H/GTSjNb4WrjKoR2rqvFxR/DDTqYNk6uXn8BJMEcncLSpMbf/XV1aS0jAjYwn98uvVCiAywQ== @@ -793,14 +793,7 @@ semver "^7.3.7" tsutils "^3.21.0" -"@typescript-eslint/experimental-utils@^5.0.0": - version "5.42.0" - resolved "https://registry.yarnpkg.com/@typescript-eslint/experimental-utils/-/experimental-utils-5.42.0.tgz#a2b6b24c75bf41ce22501f8669082efdac689909" - integrity sha512-B51HySW9wWIwLantEMqJi0FXVp1IMKRAyNASrYhJV3/nl4r6aEz6FJTJtscgu7YrGWigs7OypQExmcVqGQoDFQ== - dependencies: - "@typescript-eslint/utils" "5.42.0" - -"@typescript-eslint/parser@^5.8.1": +"@typescript-eslint/parser@^5.42.0": version "5.42.0" resolved "https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-5.42.0.tgz#be0ffbe279e1320e3d15e2ef0ad19262f59e9240" integrity sha512-Ixh9qrOTDRctFg3yIwrLkgf33AHyEIn6lhyf5cCfwwiGtkWhNpVKlEZApi3inGQR/barWnY7qY8FbGKBO7p3JA== @@ -846,7 +839,7 @@ semver "^7.3.7" tsutils "^3.21.0" -"@typescript-eslint/utils@5.42.0": +"@typescript-eslint/utils@5.42.0", "@typescript-eslint/utils@^5.10.0": version "5.42.0" resolved "https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-5.42.0.tgz#f06bd43b9a9a06ed8f29600273240e84a53f2f15" integrity sha512-JZ++3+h1vbeG1NUECXQZE3hg0kias9kOtcQr3+JVQ3whnjvKuMyktJAAIj6743OeNPnGBmjj7KEmiDL7qsdnCQ== @@ -1230,7 +1223,7 @@ chownr@^2.0.0: resolved "https://registry.yarnpkg.com/chownr/-/chownr-2.0.0.tgz#15bfbe53d2eab4cf70f18a8cd68ebe5b3cb1dece" integrity sha512-bIomtDF5KGpdogkLd9VspvFzk9KfpyyGlS8YFVZl7TGPBHL5snIOnxeshwVgPteQ9b4Eydl+pVbIyE1DcvCWgQ== -ci-info@^3.2.0, ci-info@^3.3.0: +ci-info@^3.2.0, ci-info@^3.4.0: version "3.5.0" resolved "https://registry.yarnpkg.com/ci-info/-/ci-info-3.5.0.tgz#bfac2a29263de4c829d806b1ab478e35091e171f" integrity sha512-yH4RezKOGlOhxkmhbeNuC4eYZKAUsEaGtBuBzDDP1eFUKiccDWzBABxBfOx31IDwDIXMTxWuwAxUGModvkbuVw== @@ -1585,7 +1578,7 @@ escape-string-regexp@^4.0.0: resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-4.0.0.tgz#14ba83a5d373e3d311e5afca29cf5bfad965bf34" integrity sha512-TtpcNJ3XAzx3Gq8sWRzJaVajRs0uVxA2YAkdb1jm2YkPz4G6egUFAyA3n5vtEIZefPk5Wa4UXbKuS5fKkJWdgA== -eslint-config-prettier@^8.3.0: +eslint-config-prettier@^8.5.0: version "8.5.0" resolved "https://registry.yarnpkg.com/eslint-config-prettier/-/eslint-config-prettier-8.5.0.tgz#5a81680ec934beca02c7b1a61cf8ca34b66feab1" integrity sha512-obmWKLUNCnhtQRKc+tmnYuQl0pFU1ibYJQ5BGhTVB08bHe9wC8qUeG7c08dj9XX+AuPj1YSGSQIHl1pnDHZR0Q== @@ -1605,7 +1598,7 @@ eslint-module-utils@^2.7.3: dependencies: debug "^3.2.7" -eslint-plugin-import@^2.25.3: +eslint-plugin-import@^2.26.0: version "2.26.0" resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.26.0.tgz#f812dc47be4f2b72b478a021605a59fc6fe8b88b" integrity sha512-hYfi3FXaM8WPLf4S1cikh/r4IxnO6zrhZbEGz2b660EJRbuxgpDS5gkCuYgGWg2xxh2rBuIr4Pvhve/7c31koA== @@ -1624,12 +1617,12 @@ eslint-plugin-import@^2.25.3: resolve "^1.22.0" tsconfig-paths "^3.14.1" -eslint-plugin-jest@^25.3.3: - version "25.7.0" - resolved "https://registry.yarnpkg.com/eslint-plugin-jest/-/eslint-plugin-jest-25.7.0.tgz#ff4ac97520b53a96187bad9c9814e7d00de09a6a" - integrity sha512-PWLUEXeeF7C9QGKqvdSbzLOiLTx+bno7/HC9eefePfEb257QFHg7ye3dh80AZVkaa/RQsBB1Q/ORQvg2X7F0NQ== +eslint-plugin-jest@^27.1.4: + version "27.1.4" + resolved "https://registry.yarnpkg.com/eslint-plugin-jest/-/eslint-plugin-jest-27.1.4.tgz#bdfaf51ee9ed0b86dac1e83753e22da072acaa92" + integrity sha512-evJ9E9id/z2Fu6LR+ncNySJ6UMs5RiJiv4JsmdA3gPWoq0AR+uZyva738+Y9Uln+3WaYX+3OYP9HJoau94Iurg== dependencies: - "@typescript-eslint/experimental-utils" "^5.0.0" + "@typescript-eslint/utils" "^5.10.0" eslint-plugin-json@^3.1.0: version "3.1.0" @@ -1639,29 +1632,29 @@ eslint-plugin-json@^3.1.0: lodash "^4.17.21" vscode-json-languageservice "^4.1.6" -eslint-plugin-simple-import-sort@^7.0.0: - version "7.0.0" - resolved "https://registry.yarnpkg.com/eslint-plugin-simple-import-sort/-/eslint-plugin-simple-import-sort-7.0.0.tgz#a1dad262f46d2184a90095a60c66fef74727f0f8" - integrity sha512-U3vEDB5zhYPNfxT5TYR7u01dboFZp+HNpnGhkDB2g/2E4wZ/g1Q9Ton8UwCLfRV9yAKyYqDh62oHOamvkFxsvw== +eslint-plugin-simple-import-sort@^8.0.0: + version "8.0.0" + resolved "https://registry.yarnpkg.com/eslint-plugin-simple-import-sort/-/eslint-plugin-simple-import-sort-8.0.0.tgz#9d9a2372b0606e999ea841b10458a370a6ccc160" + integrity sha512-bXgJQ+lqhtQBCuWY/FUWdB27j4+lqcvXv5rUARkzbeWLwea+S5eBZEQrhnO+WgX3ZoJHVj0cn943iyXwByHHQw== -eslint-plugin-unicorn@^40.0.0: - version "40.1.0" - resolved "https://registry.yarnpkg.com/eslint-plugin-unicorn/-/eslint-plugin-unicorn-40.1.0.tgz#48975360e39d23df726e4b33e8dd5d650e184832" - integrity sha512-y5doK2DF9Sr5AqKEHbHxjFllJ167nKDRU01HDcWyv4Tnmaoe9iNxMrBnaybZvWZUaE3OC5Unu0lNIevYamloig== +eslint-plugin-unicorn@^44.0.2: + version "44.0.2" + resolved "https://registry.yarnpkg.com/eslint-plugin-unicorn/-/eslint-plugin-unicorn-44.0.2.tgz#6324a001c0a5e2ac00fb51b30db27d14c6c36ab3" + integrity sha512-GLIDX1wmeEqpGaKcnMcqRvMVsoabeF0Ton0EX4Th5u6Kmf7RM9WBl705AXFEsns56ESkEs0uyelLuUTvz9Tr0w== dependencies: - "@babel/helper-validator-identifier" "^7.15.7" - ci-info "^3.3.0" + "@babel/helper-validator-identifier" "^7.19.1" + ci-info "^3.4.0" clean-regexp "^1.0.0" eslint-utils "^3.0.0" esquery "^1.4.0" indent-string "^4.0.0" - is-builtin-module "^3.1.0" + is-builtin-module "^3.2.0" lodash "^4.17.21" pluralize "^8.0.0" read-pkg-up "^7.0.1" regexp-tree "^0.1.24" safe-regex "^2.1.1" - semver "^7.3.5" + semver "^7.3.7" strip-indent "^3.0.0" eslint-scope@^5.1.1: @@ -2280,7 +2273,7 @@ is-boolean-object@^1.1.0: call-bind "^1.0.2" has-tostringtag "^1.0.0" -is-builtin-module@^3.1.0: +is-builtin-module@^3.2.0: version "3.2.0" resolved "https://registry.yarnpkg.com/is-builtin-module/-/is-builtin-module-3.2.0.tgz#bb0310dfe881f144ca83f30100ceb10cf58835e0" integrity sha512-phDA4oSGt7vl1n5tJvTWooWWAsXLY+2xCnxNqvKhGEzujg+A43wPlPOyDg3C8XQHN+6k/JTQWJ/j0dQh/qr+Hw== From 4be80214d761f284f3fc27b0113dc062c82469c1 Mon Sep 17 00:00:00 2001 From: Alexander Kachkaev Date: Sat, 5 Nov 2022 15:43:20 +0000 Subject: [PATCH 5/5] Tweak comment --- .eslintrc.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 4909731..131c0da 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -4,8 +4,8 @@ module.exports = { reportUnusedDisableDirectives: true, rules: { /* eslint-disable @typescript-eslint/naming-convention */ - "unicorn/prefer-module": "off", // Can be enabled after switching to ESM or Node.js >=16 - "unicorn/prefer-node-protocol": "off", // Can be enabled after switching to ESM or Node.js >=16 + "unicorn/prefer-module": "off", // Can be enabled after switching to ESM + "unicorn/prefer-node-protocol": "off", // Can be enabled after switching to ESM or dropping Node.js 14 /* eslint-enable @typescript-eslint/naming-convention */ }, };