Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling on server for all modal calls #60

Open
JeffUberman opened this issue Sep 30, 2015 · 4 comments
Open

error handling on server for all modal calls #60

JeffUberman opened this issue Sep 30, 2015 · 4 comments
Assignees
Labels

Comments

@JeffUberman
Copy link
Contributor

front-end errors with duplicate ingredients/recipes

@JeffUberman JeffUberman changed the title error handling error handling for duplicate recipes/ingredients Sep 30, 2015
@mishasaggi mishasaggi assigned mishasaggi and unassigned mishasaggi Oct 3, 2015
@mishasaggi mishasaggi removed the ready label Oct 3, 2015
@mishasaggi mishasaggi changed the title error handling for duplicate recipes/ingredients error handling on server for all modal calls Oct 3, 2015
@mishasaggi mishasaggi added ready and removed ready labels Oct 3, 2015
@mishasaggi mishasaggi self-assigned this Oct 5, 2015
@mishasaggi
Copy link
Member

running a migration on server start (handle below error)
Unhandled rejection Error: ENOENT, scandir '/Users/monisha/code/whatthefridge/migrations'
at Error (native)

@mishasaggi
Copy link
Member

Error handling across features (turn off error displaying)

Errors that should be shown (a different page or modal?)
caused by users, like validation

Errors that should be hidden (should cause a delay, worst case)
if it can be handled by code, just log it
example database/server connections

Errors that should be shown as generic
example database connection refused. display generic error instead of actual the problem

@mishasaggi
Copy link
Member

Error handling todos

errors to display to users (client side validation)

duplicate recipe name (toast it) for create recipe, edit recipe

any controller based error - log it. Not just the error but all variables being used by the method as well (all of http request), timestamp.

any http error - 400s, 500s - design the views with funny messages (rotates the message) for that and links to the dashboard.

on serious errors - send email/text to team/oncall person

@mishasaggi
Copy link
Member

Use cases not covered by error handling:

Login - user not found, password incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants