Skip to content

Commit 2ea1845

Browse files
committed
Add Node 20 and remove 14
See https://nodejs.dev/en/about/releases/ for more information.
1 parent 9f92fba commit 2ea1845

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

.devcontainer/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ RUN echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
1414
&& chmod 0440 /etc/sudoers.d/$USERNAME
1515
USER $USERNAME
1616
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | bash
17-
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 14.20.0 && nvm i --no-progress 16.17.1 && nvm i --no-progress 18.11.0 && nvm i --no-progress 19.0.0 " ]
17+
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 16.20.0 && nvm i --no-progress 18.16.0 && nvm i --no-progress 19.9.0 && nvm i --no-progress 20.0.0" ]
1818
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 19" ]
1919
ENV DEBIAN_FRONTEND=dialog

.github/workflows/build.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
strategy:
3737
fail-fast: false
3838
matrix:
39-
node: ["14.x", "16.x", "18.x", "19.x"]
39+
node: ["16.x", "18.x", "19.x", "20.x"]
4040
runner: ["windows-latest", "ubuntu-latest", "macos-latest"]
4141
steps:
4242
- uses: actions/checkout@v2
@@ -71,7 +71,7 @@ jobs:
7171
strategy:
7272
fail-fast: false
7373
matrix:
74-
node: ["14", "16", "18", "19"]
74+
node: ["16", "18", "19", "20"]
7575
steps:
7676
- uses: actions/checkout@v2
7777
- uses: uraimo/run-on-arch-action@v2.1.1
@@ -122,7 +122,7 @@ jobs:
122122
- uses: actions/checkout@v2
123123
- uses: actions/setup-node@v2
124124
with:
125-
node-version: 14.x
125+
node-version: 20.x
126126
registry-url: "https://registry.npmjs.org"
127127
- run: |
128128
node --version

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "chromedriver",
3-
"version": "112.0.0",
3+
"version": "112.0.1",
44
"keywords": [
55
"chromedriver",
66
"selenium"
@@ -41,6 +41,6 @@
4141
"typescript": "^4.9.3"
4242
},
4343
"engines": {
44-
"node": ">=14"
44+
"node": ">=16"
4545
}
4646
}

testInstall.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const os = require('os');
66
const path = require('path');
77
const fs = require('fs');
88
const spawnSync = require('child_process').spawnSync;
9-
const versions = ['14', '16', '18', '19'];
9+
const versions = ['16', '18', '19', '20'];
1010
const tempInstallPath = path.resolve(os.tmpdir(), 'chromedriver-test');
1111
const packedFile = path.resolve(tempInstallPath, 'chromedriver.tgz');
1212

0 commit comments

Comments
 (0)