From 942a81528c935c20fb95f00b26d4d1b091d0629d Mon Sep 17 00:00:00 2001 From: Gireesh Punathil Date: Tue, 3 Nov 2020 12:32:00 +0530 Subject: [PATCH] doc: add meeting minutes for 28th October Fixes: https://github.com/nodejs/diagnostics/issues/438 --- wg-meetings/2020-10-28.md | 64 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 wg-meetings/2020-10-28.md diff --git a/wg-meetings/2020-10-28.md b/wg-meetings/2020-10-28.md new file mode 100644 index 0000000..d7f3b27 --- /dev/null +++ b/wg-meetings/2020-10-28.md @@ -0,0 +1,64 @@ +# Node.js Diagnostics WorkGroup Meeting 2020-10-28 + +## Links + +* **Recording**: https://www.youtube.com/watch?v=kjgGc1_KcuQ +* **GitHub Issue**: https://github.com/nodejs/diagnostics/issues/438 +* **Minutes Google Doc**: https://docs.google.com/document/d/1-rm5JJxdq9Muwd4oqufhE6gP4xyu0Ob8g7Fc_FcLUyA/edit + +## Present + +* Diagnostics team: @nodejs/diagnostics +* Stephen Belanger (@qard) +* Rafael Gonzaga (@rafaelgss) +* Michael Dawson (@mhdawson) +* Chengzhong Wu (@legendecas) +* Gireesh Punathil (@gireeshpunathil) + + +## Agenda + +## Announcements + +*Extracted from **diag-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting. + +### nodejs/node + +* lib: add span API to diagnostics_channel [#35534](https://github.com/nodejs/node/pull/35534) + * Waiting on diagnostics channel to land first + +* lib: make diagnostics_channel async iterable [#35532](https://github.com/nodejs/node/pull/35532) + * Waiting on diagnostics channel to land first + +* Proposal: mark AsyncResource and AsyncLocalStorage as stable [#35286](https://github.com/nodejs/node/issues/35286) + * Seems like there is consensus that AsyncResource should be able to become stable + * For AsyncLocalStorage, we need to come up/agree exit criteria. Gireesh pasted in + Starting point for exit criteria based on previous features that went experimental->stable + https://github.com/nodejs/node/issues/35286#issuecomment-708899145 + +* lib: create diagnostics_channel module [#34895](https://github.com/nodejs/node/pull/34895) + * Waiting on reviews, needs more TSC approvals + +* Node.js' internal scripts should be hidden in the inspector. [#11893](https://github.com/nodejs/node/issues/11893) + * wait until we have Mary who might have a better insight + +### nodejs/diagnostics + +* Identify async_hooks use cases beyond AsyncLocalStorage [#437](https://github.com/nodejs/diagnostics/issues/437) + * Good start on getting some feedback/capture the use case + +* Add ioredis to problematic-modules.md [#430](https://github.com/nodejs/diagnostics/pull/430) + * Just waiting on replacement issues to be opened. + +* Node CPU Profiling Roadmap [#148](https://github.com/nodejs/diagnostics/issues/148) + * skip for this week as Mary is Champion/has context + +* \[async_hooks\] stable API - tracking issue [#124](https://github.com/nodejs/diagnostics/issues/124) + * closed in favor of https://github.com/nodejs/diagnostics/issues/437 + + +## Q&A, Other + +## Upcoming Meetings + +* **Node.js Foundation Calendar**: https://nodejs.org/calendar