From 0cc789d81d9ea3d8e0de2b918349280f89276f25 Mon Sep 17 00:00:00 2001 From: Liang Zheng Date: Wed, 29 Dec 2021 19:07:34 +0800 Subject: [PATCH] update dump db tool Signed-off-by: Liang Zheng --- server/lease/leasehttp/http.go | 2 +- server/storage/mvcc/index.go | 4 ++-- server/storage/mvcc/kvstore.go | 2 +- tools/etcd-dump-db/backend.go | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/lease/leasehttp/http.go b/server/lease/leasehttp/http.go index 3539305863d..542c3a82a0c 100644 --- a/server/lease/leasehttp/http.go +++ b/server/lease/leasehttp/http.go @@ -236,7 +236,7 @@ func TimeToLiveHTTP(ctx context.Context, id lease.LeaseID, keys bool, url string return nil, fmt.Errorf(`lease: %v. data = "%s"`, err, string(b)) } if lresp.LeaseTimeToLiveResponse.ID != int64(id) { - return nil, fmt.Errorf("lease: renew id mismatch") + return nil, fmt.Errorf("lease: TTL id mismatch") } return lresp, nil } diff --git a/server/storage/mvcc/index.go b/server/storage/mvcc/index.go index 0a5cb005160..13cbc9b8bc2 100644 --- a/server/storage/mvcc/index.go +++ b/server/storage/mvcc/index.go @@ -218,8 +218,8 @@ func (ti *treeIndex) Compact(rev int64) map[revision]struct{} { clone.Ascend(func(item btree.Item) bool { keyi := item.(*keyIndex) - //Lock is needed here to prevent modification to the keyIndex while - //compaction is going on or revision added to empty before deletion + // Lock is needed here to prevent modification to the keyIndex while + // compaction is going on or revision added to empty before deletion ti.Lock() keyi.compact(ti.lg, rev, available) if keyi.isEmpty() { diff --git a/server/storage/mvcc/kvstore.go b/server/storage/mvcc/kvstore.go index 3c0a60bef68..dbf59239c14 100644 --- a/server/storage/mvcc/kvstore.go +++ b/server/storage/mvcc/kvstore.go @@ -142,7 +142,7 @@ func (s *store) compactBarrier(ctx context.Context, ch chan struct{}) { select { case <-s.stopc: default: - // fix deadlock in mvcc,for more information, please refer to pr 11817. + // fix deadlock in mvcc, for more information, please refer to pr 11817. // s.stopc is only updated in restore operation, which is called by apply // snapshot call, compaction and apply snapshot requests are serialized by // raft, and do not happen at the same time. diff --git a/tools/etcd-dump-db/backend.go b/tools/etcd-dump-db/backend.go index a0e14bc679a..7962007f8b1 100644 --- a/tools/etcd-dump-db/backend.go +++ b/tools/etcd-dump-db/backend.go @@ -95,7 +95,7 @@ func leaseDecoder(k, v []byte) { if err := lpb.Unmarshal(v); err != nil { panic(err) } - fmt.Printf("lease ID=%016x, TTL=%ds\n", leaseID, lpb.TTL) + fmt.Printf("lease ID=%016x, TTL=%ds, remaining TTL=%ds\n", leaseID, lpb.TTL, lpb.RemainingTTL) } func authDecoder(k, v []byte) {