Do not force-set HOME variable, let nsswitch decide #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous versions of Git/msys1 did not check for the correct location of the user profile on Windows, thus requiring the HOME variable to be set. Since Git 2 nsswitch is used to identify the correct location of the user profile. For non-roaming domain userprofiles, where USERPROFILE still remains on drive C:\, but with an additional home drive set, this line breaks search for the SSH key, since nsswitch returns the correct results, but HOME is used instead, since it has been already set by start-ssh-agent.cmd. Signed-off-by: Nathan-J. Hirschauer <nathan-jedidja.hirschauer@draeger.com>
|
Seems reasonable to me. I'm not an SSH expert though, so my comments carry little weight. 😏 |
dscho
added a commit
that referenced
this pull request
Jun 21, 2018
This file had been modified in #26 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Makes sense to me, too. Thank you so much for your contribution! I updated the checksums in ed959f7 so that |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Jun 21, 2018
The `start-ssh-agent.cmd` script [no longer overrides the `HOME` variable](git-for-windows/MINGW-packages#26). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of Git/msys1 did not check for the
correct location of the user profile on Windows, thus
requiring the HOME variable to be set. Since Git 2 nsswitch
is used to identify the correct location of the user profile.
For non-roaming domain userprofiles, where USERPROFILE still
remains on drive C:, but with an additional home drive set,
this line breaks search for the SSH key, since nsswitch returns
the correct results, but HOME is used instead, since it has been
already set by start-ssh-agent.cmd.