Skip to content

Commit

Permalink
WIP: installer (64-bit): remove 2GB pack size limit
Browse files Browse the repository at this point in the history
TODO: test!!!

In 64-bit setups it does not make sense to limit the pack size to 2GB.

This fixes git-for-windows/git#288.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho committed Aug 19, 2015
1 parent 85541b4 commit ec06b09
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions installer/install.iss.in
Original file line number Diff line number Diff line change
Expand Up @@ -1352,6 +1352,28 @@ begin
end;
end;
if FileExists(ProgramData + '\Git\config') then begin
#ifdef IS64
FileName:=ExpandConstant('{tmp}')+'\packsize.txt';
if not Exec(AppDir+'\{#MINGW_BITNESS}\bin\git.exe','config -f config pack.packsizelimit > "'+FileName+'"',SW_HIDE,ewWaitUntilTerminated,i) then begin
Msg:='Unable to read packsize limit';

// This is not a critical error, so just notify the user and continue.
SuppressibleMsgBox(Msg,mbError,MB_OK,IDOK);
Log(Msg);
end else if not LoadStringFromFile(FileName,PackSizeLimit) then begin
Msg:='Unable to read redirected packsize limit';
// This is not a critical error, so just notify the user and continue.
SuppressibleMsgBox(Msg,mbError,MB_OK,IDOK);
Log(Msg);
end else if (PackSizeLimit='2g\n') and not Exec(AppDir+'\{#MINGW_BITNESS}\bin\git.exe','config -f config --unset pack.packsizelimit',SW_HIDE,ewWaitUntilTerminated,i) then begin
Msg:='Unable to unset packsize limit';

// This is not a critical error, so just notify the user and continue.
SuppressibleMsgBox(Msg,mbError,MB_OK,IDOK);
Log(Msg);
end;
DeleteFile(FileName);
#endif
Cmd:='http.sslCAInfo "' + AppDir + '/{#MINGW_BITNESS}/ssl/certs/ca-bundle.crt"';
StringChangeEx(Cmd,'\','/',True);
if not Exec(AppDir+'\{#MINGW_BITNESS}\bin\git.exe','config -f config '+Cmd,
Expand Down

0 comments on commit ec06b09

Please sign in to comment.