Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the "Next" button's label to "Install" on the last wizard page before installation #104

Merged
merged 2 commits into from
Mar 25, 2016

Conversation

dscho
Copy link
Member

@dscho dscho commented Mar 21, 2016

It's just a very nice visual indicator for the user that things are about to get real.

dscho added 2 commits March 21, 2016 16:39
Compressing the entire set of files really takes a long time...

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The last wizard page before the installation starts should give the user
an indication that this is what is going to happen.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho referenced this pull request Mar 21, 2016
On some monitors, the link to the Credential Manager looks blurred. The
reason: in InnoSetup, you can only register a mouse click action per
label, so we overlay the label with another label containing just the
hyperlink. This is tricky to get right, though, as the font metrics
differ between systems.

Instead, let's just use an appropriate number of spaces and fudge the
offset a little bit so that it looks correct enough.

Reported by Pablo Nunez Navarro.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho merged commit d38b527 into git-for-windows:master Mar 25, 2016
@dscho dscho deleted the installer-buttons branch March 25, 2016 12:27
dscho added a commit that referenced this pull request Mar 29, 2016
The installer [now changes the label of the `Next` button to
`Install`](#104)
on the last wizard page before installing.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant