rename "git update" to "git update-git-for-windows" #167
Conversation
|
Fully agree on this, it makes sense to rename that, |
|
Thanks. I also contemplated about |
|
FWIW I like |
git-extra/PKGBUILD
Outdated
| @@ -115,6 +115,6 @@ package() { | |||
| install -m644 msys2-32.ico $pkgdir/usr/share/git | |||
| install -m644 99-post-install-cleanup.post $pkgdir/etc/post-install | |||
| install -m755 astextplain $pkgdir/usr/bin | |||
| install -m755 git-update $pkgdir${MINGW_PREFIX}/libexec/git-core | |||
| install -m755 git-upgrade $pkgdir${MINGW_PREFIX}/libexec/git-core | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Sounds like @between2spaces, @viceice, @landstander668 : you helped on the initial |
|
Looks good to me. 👍 |
larsxschneider
force-pushed
the
lars/rename-update
branch
2 times, most recently
from
6e06d83 to
9ede042
Compare
git-extra/git-self-upgrade
Outdated
| @@ -237,7 +237,7 @@ git_update () { | |||
| esac | |||
| elif test -n "$use_gui" | |||
| then | |||
| git gui--askyesno --title "Git Update Available" \ | |||
| git gui--askyesno --title "Git Upgrade Available" \ | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
I've changed it to |
larsxschneider
changed the title
|
@dscho What is the best way to test this PR? I've installed the latest 64 SDK. The first lars@winbox MINGW64 /usr/src/build-extra (lars/rename-update)
$ ./please.sh sync
No 32-bit Git for Windows SDK found at location:
C:/git-sdk-32
Config variable to override: windows.sdk32.path
:: Synchronizing package databases...
git-for-windows is up to date
git-for-windows-mingw32 12.7 KiB 530K/s 00:00 [#####################] 100%
git-for-windows-min... 543.0 B 0.00B/s 00:00 [#####################] 100%
mingw32 is up to date
mingw64 is up to date
msys is up to date
error launching git: The filename, directory name, or volume label syntax is inc orrect.
Could not update packages in
lars@winbox MINGW64 /usr/src/build-extra (lars/rename-update)
$ ./please.sh build git
No 32-bit Git for Windows SDK found at location:
C:/git-sdk-32
Config variable to override: windows.sdk32.path
./please.sh: line 390: cd: C:/git-sdk-64//usr/src/MINGW-packages/mingw-w64-git: No such file or directory
C:/git-sdk-64//usr/src/MINGW-packages/mingw-w64-git does not exist
Could not run 'pkg_build' in 'C:/git-sdk-64'Building |
|
@dscho Do you agree with this change in general? If yes, can you give me advice how I can move it forward? |
|
First of all, these errors you got all stem from I kinda assumed that contributors would use But you are right, it would be nice if As to moving this change forward, I wanted to let it simmer a little bit because I had a hunch that |
|
Naming is hard 😄 Although I slightly prefer However, since we don't want to change it every other day I am not against simmering a little further. What do you think about the following? My goal is to make it as clear as possible that we don't talk about source control update functions here. |
Well, then we absolutely need a name that makes this abundandly clear, like My gripe with |
Yeah, especially because it is (I think) unlikely that this command will ever exist for Linux or macOS as Git is distributed via package management systems there. I wonder how common the abbreviation |
|
I like |
I don't like to abbreviate Git for Windows, personally, I saw GfW and G4W in the wild, but as we are trying to be abundantly clear, we cannot abbreviate it in the command anyway. |
In 1da13c5 (Keep Git for Windows up to date via the command-line, 2017-08-11) we added a command to download and install the latest Git for Windows version. We called this command "git update". Users, especially Git novices, could easily view the verb "update" as Git version control operation. Fix the ambiguity by renaming it to "update-git-for-windows". Signed-off-by: Lars Schneider <larsxschneider@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
In the Git for Windows project, we learned the hard way, several times, that it is not good to just remove or rename stuff without giving the users a chance to adjust. In this instance, we just renamed `git update` to `git update-git-for-windows`, and unless the user reads the release notes (and let's be honest: only a teeny tiny fraction of the users read those), she has no chance of knowing what to do next. So let's be nice and add back the `git update` command; it will output the deprecation notice and hand off to the `update-git-for-windows` subcommand. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
lars/rename-update
branch
from
9ede042 to
e4a51fd
Compare
dscho
changed the title
The `git update` command [has been renamed to `git update-git-for-windows`](#167) to avoid confusion where users may think that `git update` updates their local repository or worktree. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Thanks @dscho 🎉 |
|
@dscho Do you plan to remove the |
|
Yes, of course. |
Is now a good time to do it? |
|
@Klonan yes! If you would prepare a PR, please? |
|
@dscho Oh I am not really a C++ type person, I only saw this because my VSCode told me to update, and it came up with deprecation notice. |
Lucky you: no C++ is involved. All you need to do is to remove the |
|
You really want me to do it? |
Well, I welcome contributions, so that the burden of developing Git for Windows does not lie exclusively with me. So yes, I am happy when people step a bit outside their regular expertise, learn something new, and contribute. |
Pls don't. I find it pretty tedious to type. As long as there is a warning as to what |
I just created an alias |
|
The problem with squatting on a short-and-neat name like The name is also too generic and not descriptive enough: "update? Update... what? What exactly is Git updating here? My worktree?" So yes, that The good news is that you can install an alias of that name, and not notice when only the |
In 1da13c5 (Keep Git for Windows up to date via the command-line,
2017-08-11) we added a command to download and install the latest
Git for Windows version. We called this command "git update".
Users, especially Git novices, could easily view the verb "update" as
Git version control operation. Fix the ambiguity by renaming it to
"self-upgrade".