Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2537 add VSCodium #278

Merged
merged 1 commit into from
Mar 8, 2020
Merged

Fix #2537 add VSCodium #278

merged 1 commit into from
Mar 8, 2020

Conversation

GitMensch
Copy link
Contributor

@GitMensch GitMensch commented Mar 8, 2020

and minor change in the text to VisualStudioCode to distinguish its MIT-licensed "core" with the provided un-free binaries (+telemetry/tracking) between the option added.

As the reference was not 100% clean - this fixes git-for-windows/git#2537.

The VSCodium project aims to provide a Free/Libre version of Visual
Studio Code, and this patch lets the Git for Windows installer detect
its presence when offering editors for use with Git.

Signed-off-by: Simon Sobisch <simonsobisch@web.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
installer/install.iss Outdated Show resolved Hide resolved
installer/install.iss Outdated Show resolved Hide resolved
@dscho dscho merged commit 9004ef8 into git-for-windows:master Mar 8, 2020
dscho added a commit that referenced this pull request Mar 8, 2020
The Free/Libre [VSCodium](https://vscodium.com/) version of
[Visual Studio Code](https://code.visualstudio.com) is now [also
detected](#278)
as an option for the default Git editor.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@GitMensch GitMensch deleted the vscodium branch March 8, 2020 21:36
@dscho
Copy link
Member

dscho commented Apr 30, 2020

@GitMensch Hmm. Bad news. VS Codium, despite its good intentions, seems to violate Visual Studio's Marketplace terms:

section 1.b, sentence 2

Marketplace Offerings are intended for use only with Visual Studio Products and Services and you may only install and use Marketplace Offerings with Visual Studio Products and Services.

We might have to kick VS Codium out of Git for Windows' installer unless that issue is resolved.

@GitMensch
Copy link
Contributor Author

GitMensch commented Apr 30, 2020

See the according documentation at https://github.com/VSCodium/vscodium/blob/master/DOCS.md#extensions-marketplace and issues about this on the vscode repo like microsoft/vscode#1557.
Further on the vscode repo (licensed under MIT) uses the marketplace extension api (the code for this is MIT-licensed and this part seems to be covered under a different point) so if something at all is "questionable" is the URL address to the marketplace in the project.json, correct?

Note: there's work in progress in vscodium to move from the MS marketplace to the Open VSX Repository, so maybe leaving this "open" until then?

@dscho
Copy link
Member

dscho commented May 1, 2020

I just need to know that this is being addressed.

It was very concerning to me to see a blatant violation of terms by a project that wants to claim high moral ground. That's just not right.

@GitMensch
Copy link
Contributor Author

Just as an update: if the user doesn't manually switch to any other extension provider then the default (with each vscodium installation/update) is the Open VSX Registry, not the ms-marketplace.

@dscho
Copy link
Member

dscho commented Jun 25, 2020

That's good, but it should not even offer the marketplace, as it is a violation of terms.

@GitMensch
Copy link
Contributor Author

GitMensch commented Jun 25, 2020

It doesn't offer the MS marketplace at all, but should not prevent people from adjusting their local vscode files to point to a different extension provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer: Suggest VSCodium
2 participants