-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2537 add VSCodium #278
Conversation
The VSCodium project aims to provide a Free/Libre version of Visual Studio Code, and this patch lets the Git for Windows installer detect its presence when offering editors for use with Git. Signed-off-by: Simon Sobisch <simonsobisch@web.de> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The Free/Libre [VSCodium](https://vscodium.com/) version of [Visual Studio Code](https://code.visualstudio.com) is now [also detected](#278) as an option for the default Git editor. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@GitMensch Hmm. Bad news. VS Codium, despite its good intentions, seems to violate Visual Studio's Marketplace terms: section 1.b, sentence 2
We might have to kick VS Codium out of Git for Windows' installer unless that issue is resolved. |
See the according documentation at https://github.com/VSCodium/vscodium/blob/master/DOCS.md#extensions-marketplace and issues about this on the vscode repo like microsoft/vscode#1557. Note: there's work in progress in vscodium to move from the MS marketplace to the Open VSX Repository, so maybe leaving this "open" until then? |
I just need to know that this is being addressed. It was very concerning to me to see a blatant violation of terms by a project that wants to claim high moral ground. That's just not right. |
Just as an update: if the user doesn't manually switch to any other extension provider then the default (with each vscodium installation/update) is the Open VSX Registry, not the ms-marketplace. |
That's good, but it should not even offer the marketplace, as it is a violation of terms. |
It doesn't offer the MS marketplace at all, but should not prevent people from adjusting their local vscode files to point to a different extension provider. |
and minor change in the text to VisualStudioCode to distinguish its MIT-licensed "core" with the provided un-free binaries (+telemetry/tracking) between the option added.
As the reference was not 100% clean - this fixes git-for-windows/git#2537.