Add Git FAQ icon to start menu linking to the wiki/FAQ #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does that really work if you use a URL for a filename? |
Yes it does. I was concerned too. Note that the
The examples then shows the dropping of the I now see that I could have dropped the |
From the Innosetup [Icons] section https://jrsoftware.org/ishelp/index.php?topic=iconssection "In addition to file and folder names, URLs (web site addresses) may also be specified. When a URL is specified, Setup will create an "Internet Shortcut" (.url) file, and ignore the Parameters, WorkingDir, HotKey, and Comment parameters." Their example also shows the '{app}' path portion also being dropped. Signed-off-by: Philip Oakley <philipoakley@iee.email>
|
Updated the commit message, and tweaked the changes to drop the no longer required parameters for the Icon setup. |
|
Thanks! |
dscho
added a commit
that referenced
this pull request
May 3, 2020
The Frequently Asked Questions (FAQ) [are now linked in a Start Menu item](#283). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philip Oakley philipoakley@iee.email
Note that the icons are listed in alphabetic order on W10 start menu (on my machine), so we have:
Bash, CMD, FAQs, GUI, Release Notes.