git-askpass: don't expect a prompt #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSSH considers the prompt an optional parameter to their ssh-askpass [1] and calls git-askpass without a prompt as well. Provide a default prompt that instead of erroring out. This fixes git-for-windows/git#3434 [1] https://man.openbsd.org/ssh-askpass.1 Signed-off-by: Matthias Aßhauer <mha1993@live.de> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
askpass-default-prompt
branch
from
ae54d35 to
73ce12f
Compare
|
Thank you! |
dscho
added a commit
that referenced
this pull request
Oct 4, 2021
The password prompt when cloning via SSH [works again](#381). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSH considers the prompt an optional parameter
to their ssh-askpass and calls git-askpass without
a prompt as well. Provide a default prompt that instead
of erroring out.
This fixes git-for-windows/git#3434