Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placing git-lfs documentation in right place #491

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Placing git-lfs documentation in right place #491

merged 4 commits into from
Mar 29, 2023

Conversation

jasonnicholson
Copy link
Contributor

@jasonnicholson jasonnicholson commented Mar 28, 2023

The PKGBUILD file was updated to move the html documentation to the right location.

@dscho here is your pull request per our conversation git-for-windows/git#4327.

Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

Before accepting the PR, I would like to ask for two things:

  • Please use your real email address in the Signed-off-by line (in the commit message; There is no need to add the Signed-off-by line to the PR description). The idea is that people can contact you in case of, say, proposed license changes. A .noreply.github.com address won't cut it.
  • Please increment the pkgrel number, so that we can deploy a new package version in this Pull Request.

mingw-w64-git-lfs/PKGBUILD Outdated Show resolved Hide resolved
mingw-w64-git-lfs/PKGBUILD Outdated Show resolved Hide resolved
@jasonnicholson
Copy link
Contributor Author

jasonnicholson commented Mar 28, 2023

Thank you for working on this.

Before accepting the PR, I would like to ask for two things:

  • Please use your real email address in the Signed-off-by line (in the commit message; There is no need to add the Signed-off-by line to the PR description). The idea is that people can contact you in case of, say, proposed license changes. A .noreply.github.com address won't cut it.

  • Please increment the pkgrel number, so that we can deploy a new package version in this Pull Request.

I think I did everything you asked.

jasonnicholson and others added 2 commits March 28, 2023 09:41
The PKGBUILD file was updated to move the html documentation
to the right location.

Signed-off-by: Jason H Nicholson <jashale@yahoo.com>
Signed-off-by: Jason H Nicholson <jashale@yahoo.com>
@dscho
Copy link
Member

dscho commented Mar 29, 2023

/deploy

@dscho
Copy link
Member

dscho commented Mar 29, 2023

/deploy mingw-w64-git-lfs

The workflow run was started.

dscho added 2 commits March 29, 2023 13:03
We want `git help git-lfs` to work, but that targets the `git-doc`
directory, not the `git-core` directory.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
I had already deployed -2 before testing, then tested, and realized that
a fix was needed: the HTML pages need to go into a different directory.
So let's deploy -3.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Mar 29, 2023

/deploy mingw-w64-git-lfs

The workflow run was started.

@dscho dscho linked an issue Mar 29, 2023 that may be closed by this pull request
1 task
@dscho
Copy link
Member

dscho commented Mar 29, 2023

/add release note feature The Git for Windows installer now also includes the Git LFS documentation (i.e. git help git-lfs now works).

The workflow run was started

github-actions bot pushed a commit that referenced this pull request Mar 29, 2023
The Git for Windows installer now [also
includes](#491) the
Git LFS documentation (i.e. `git help git-lfs` now works).

Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
@dscho dscho merged commit 2a7db3f into git-for-windows:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing GIT LFS Documentation
2 participants