-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placing git-lfs documentation in right place #491
Placing git-lfs documentation in right place #491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this.
Before accepting the PR, I would like to ask for two things:
- Please use your real email address in the Signed-off-by line (in the commit message; There is no need to add the Signed-off-by line to the PR description). The idea is that people can contact you in case of, say, proposed license changes. A
.noreply.github.com
address won't cut it. - Please increment the
pkgrel
number, so that we can deploy a new package version in this Pull Request.
I think I did everything you asked. |
The PKGBUILD file was updated to move the html documentation to the right location. Signed-off-by: Jason H Nicholson <jashale@yahoo.com>
Signed-off-by: Jason H Nicholson <jashale@yahoo.com>
/deploy |
/deploy mingw-w64-git-lfs The workflow run was started. |
We want `git help git-lfs` to work, but that targets the `git-doc` directory, not the `git-core` directory. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
I had already deployed -2 before testing, then tested, and realized that a fix was needed: the HTML pages need to go into a different directory. So let's deploy -3. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
/deploy mingw-w64-git-lfs The workflow run was started. |
/add release note feature The Git for Windows installer now also includes the Git LFS documentation (i.e. The workflow run was started |
The Git for Windows installer now [also includes](#491) the Git LFS documentation (i.e. `git help git-lfs` now works). Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
The PKGBUILD file was updated to move the html documentation to the right location.
@dscho here is your pull request per our conversation git-for-windows/git#4327.