installer: sanitize GIT_* environment variables #529
Merged
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables, if set by the user, should not be heeded by the Git for Windows installer. Partially addresses git-for-windows/git#4604. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 task
|
/add relnote bug Git for Windows's installer is no longer confused by global The workflow run was started |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 21, 2023
Git for Windows's installer [is no longer confused by global `GIT_*` environment variables](#529). Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
csware
added a commit
to TortoiseGit/TortoiseGit
that referenced
this pull request
Nov 22, 2023
Prevent passing environment variables to git.exe that are currently unsupported in TortoiseGit/libgit2 to prevent inconsistencies (cf. issue #4029 and issue #3852) cf. git-for-windows/build-extra#529 Signed-off-by: Sven Strickroth <email@cs-ware.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses git-for-windows/git#4604.