git-extra: Source ~/.profile as well in generated ~/.bash_profile #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elieux just pinging in case this has been lost in the mail traffic of last year. |
Bash will prefer `~/.bash_profile` over `~/.profile`, so if we're generating `~/.bash_profile` for the user, we now insert a clause to source the original `~/.profile` to keep it from getting skipped. Signed-off-by: David Macek <david.macek.0@gmail.com>
The bash_profile.sh contained several echo statements redirecting output to the newly created ~/.bash_profile. This was rewritten to use heredoc syntax. Signed-off-by: David Macek <david.macek.0@gmail.com>
Signed-off-by: David Macek <david.macek.0@gmail.com>
|
Yeah, it did, but due to the way GitHub send email notifications, the ping got lost as well. :) I followed your advice, but now the indentation looks horrible. I also added one more change. I'm open to further requests (though it may be with a slight delay again). |
dscho
added a commit
that referenced
this pull request
Jan 7, 2016
git-extra: Source ~/.profile as well in generated ~/.bash_profile
dscho
added a commit
that referenced
this pull request
Jan 7, 2016
See #91 for the discussion. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
I decided to do this as a follow-up patch, as well as adjusting the Thanks, @elieux ! |
dscho
added a commit
that referenced
this pull request
Jan 7, 2016
See #91 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Oh shoot, I forgot about the checksums. Glad to help. |
elieux
pushed a commit
to elieux-contrib/build-extra
that referenced
this pull request
Aug 15, 2017
See git-for-windows#91 for the discussion. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bash will prefer
~/.bash_profileover~/.profile, so if we're generating~/.bash_profilefor the user, we now insert a clause to source the original~/.profileto keep it from getting skipped.As mentioned on Gitter.