From 60d8d6eae36358696027f95f0dc1a2dffc3b066b Mon Sep 17 00:00:00 2001 From: Johannes Schindelin Date: Mon, 5 Feb 2018 20:20:05 +0100 Subject: [PATCH] fixup! add support for disabling SSL revocation checks in cURL This maintainer thought that it was discussed that you cannot `strcmp()` blindly without checking for NULL first, but subsequently forgot to check that the fix had made it into the final version of the PR... :-( The problem is that this crashes any fetch/push/clone/ls-remote operation *unless* http.sslBackend is specified explicitly. This probably fixes the root cause behind https://github.com/git-for-windows/git/issues/1474. Signed-off-by: Johannes Schindelin --- http.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/http.c b/http.c index 02b7ee8c385f2b..31803d0286c87f 100644 --- a/http.c +++ b/http.c @@ -753,7 +753,8 @@ static CURL *get_curl_handle(void) } #endif - if (!strcmp("schannel", http_ssl_backend) && !http_schannel_check_revoke) { + if (http_ssl_backend && !strcmp("schannel", http_ssl_backend) && + !http_schannel_check_revoke) { #if LIBCURL_VERSION_NUM >= 0x074400 curl_easy_setopt(result, CURLOPT_SSL_OPTIONS, CURLSSLOPT_NO_REVOKE); #else