Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git 2.13.1 x64 crashes/segfaults on commit #1202

Closed
1 task done
csrakowski opened this issue Jun 14, 2017 · 11 comments
Closed
1 task done

Git 2.13.1 x64 crashes/segfaults on commit #1202

csrakowski opened this issue Jun 14, 2017 · 11 comments
Milestone

Comments

@csrakowski
Copy link

  • I was not able to find an open or closed issue matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
$ git --version --build-options

git version 2.13.1.windows.1
built from commit: 13f583bedb59f9a11b3f2e91673c10c250f84576
sizeof-long: 4
machine: x86_64
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
$ cmd.exe /c ver

Microsoft Windows [Version 10.0.15063]
  • What options did you set as part of the installation? Or did you choose the
    defaults?
# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Path Option: Cmd
SSH Option: OpenSSH
CURL Option: OpenSSL
CRLF Option: CRLFCommitAsIs
Bash Terminal Option: MinTTY
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Disabled
  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

It works/worked fine in 2.13.0

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Crash happens in PowerShell (in Cmder), Cmd and Git Bash

Either of:
git commit -am ""
git commit -m ""
git commit

  • What did you expect to occur after running these commands?

The normal commit flow

  • What actually happened instead?

Segfault :-(
I don't have the debug symbols at this time, but I have attached a screenshot of the disassembly.
If you can point me to the pdb's, I can try again with those.

git-for-windows-crash

  • If the problem was occurring with a specific repository, can you provide the
    URL to that repository to help us with testing?

N/A

@Radrik5
Copy link

Radrik5 commented Jun 14, 2017

I have segfault on checkout with git 2.13.1. The repository is private.

$ GIT_TRACE=1 git checkout clnt18x4x8011x1
13:22:07.236517 git.c:369               trace: built-in: git 'checkout' 'clnt18x4x8011x1'
Segmentation fault

@seishun
Copy link

seishun commented Jun 14, 2017

git checkout . and git diff crash for me. Same version, same trace as above.

@verkruemelt
Copy link

git commit (segfault) and git GUI crashes on loading repo.

Going back to git 2.13.0 - no problems.

@veikkoeeva
Copy link

Looks like being the same problem for me too, git checkout <anybranch> will crash with segfault.

@cvalerio
Copy link

Same issue here!

@dscho
Copy link
Member

dscho commented Jun 14, 2017

Please test with the current snapshot: https://wingit.blob.core.windows.net/files/index.html

@seishun
Copy link

seishun commented Jun 14, 2017

Works for me.

@rongjiecomputer
Copy link

Snapshot works for me.

(I am the same person in https://groups.google.com/d/msg/git-for-windows/Bsulx6y9RtI/tH3bNQ4VAAAJ)

@csrakowski
Copy link
Author

Snapshot fixed it for me too 👍

@jeyoung
Copy link

jeyoung commented Jun 15, 2017

This is happening to me, too.

D:>git --version --build-options
git version 2.13.1.windows.1
built from commit: 13f583b
sizeof-long: 4
machine: x86_64

dscho added a commit to git-for-windows/build-extra that referenced this issue Jun 15, 2017
`git commit` and `git status` [no longer randomly throw segmentation
faults](git-for-windows/git#1202).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Jun 15, 2017

Fixed in https://github.com/git-for-windows/git/releases/tag/v2.13.1.windows.2.

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants