Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-remote-https.ext crashes on blank Windows 10 #1474

Closed
a-r-m-i-n opened this issue Feb 3, 2018 · 6 comments
Closed

git-remote-https.ext crashes on blank Windows 10 #1474

a-r-m-i-n opened this issue Feb 3, 2018 · 6 comments
Milestone
v2.16.1(3)

Comments

@a-r-m-i-n
Copy link

a-r-m-i-n commented Feb 3, 2018 •
edited
Loading

Hi, I've recently reset my Windows 10 machine.
I've installed git using scoop. And everytime I perform a "git fetch" I get an error box and this entry in system log:

Name der fehlerhaften Anwendung: git-remote-https.exe, Version: 2.16.1.2, Zeitstempel: 0x5a7491f4
Name des fehlerhaften Moduls: git-remote-https.exe, Version: 2.16.1.2, Zeitstempel: 0x5a7491f4
Ausnahmecode: 0xc0000005
Fehleroffset: 0x00000000000056cd
ID des fehlerhaften Prozesses: 0x2af4
Startzeit der fehlerhaften Anwendung: 0x01d39d28f3c5c910
Pfad der fehlerhaften Anwendung: C:\Users\armin\scoop\apps\git\current\mingw64\libexec\git-core\git-remote-https.exe
Pfad des fehlerhaften Moduls: C:\Users\armin\scoop\apps\git\current\mingw64\libexec\git-core\git-remote-https.exe
Berichtskennung: bf58423d-768b-43aa-b384-10b402573d80
Vollständiger Name des fehlerhaften Pakets: 
Anwendungs-ID, die relativ zum fehlerhaften Paket ist:

I'm using version 2.16.1.windows.2 on a brand new Windows 10 set up. No clue how to fix this. Thanks for any hints!
@a-r-m-i-n
Copy link
Author

Ok. When I install it with the installer from git-scm.com, it works. Nevermind.

@dscho
Copy link
Member

dscho commented Feb 5, 2018

I think that the symptom relates to an unset http.sslBackend (although I cannot really see how that would happen when installing Git for Windows via the installer).

@dscho dscho added this to the v2.16.1(3) milestone Feb 5, 2018
dscho added a commit that referenced this issue Feb 5, 2018
@dscho
fixup! add support for disabling SSL revocation checks in cURL
60d8d6e 
This maintainer thought that it was discussed that you cannot `strcmp()`
blindly without checking for NULL first, but subsequently forgot to
check that the fix had made it into the final version of the PR... :-(

The problem is that this crashes any fetch/push/clone/ls-remote
operation *unless* http.sslBackend is specified explicitly.

This probably fixes the root cause behind
#1474.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Feb 6, 2018

FWIW even if it does not look like it, #1475 is probably describing this very same issue.

@dscho
Copy link
Member

dscho commented Feb 6, 2018

Oops. I meant #1478.

dscho added a commit to git-for-windows/build-extra that referenced this issue Feb 6, 2018
@dscho
Mention Bug Fix in release notes
1b0e8dd 
When `http.sslBackend` is not configured (e.g. in
portable Git or MinGit), fetch/push operations [no longer
crash](git-for-windows/git#1474).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@a-r-m-i-n
Copy link
Author

Should I reopen this one again? But I swear, with the installer it works ;)

@dscho
Copy link
Member

dscho commented Feb 7, 2018

Should I reopen this one again?

No, as it has been fixed in v2.16.1(3) (released yesterday).

But I swear, with the installer it works ;)

Yes, and the reason is that the installer always sets http.sslBackend... ;-) So the previously unguarded strcmp("schannel", http_ssl_backend) tried to access NULL, which will always fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.16.1(3)
Development

No branches or pull requests
2 participants
@dscho @a-r-m-i-n