Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtree push is broken #2241

Closed
1 task done
maxisam opened this issue Jun 18, 2019 · 5 comments
Closed
1 task done

Subtree push is broken #2241

maxisam opened this issue Jun 18, 2019 · 5 comments

Comments

@maxisam
Copy link

maxisam commented Jun 18, 2019

  • I was not able to find an open or closed issue matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

2.22.0 @win10 64bit

Details

git subtree push doesn't work.

The result is like this

https://public-inbox.org/git/20190101131947.GA18907@ash/

Revert back to 2.18 and it starts to work correctly. (2.19 and 2.20 don't work either)

@PhilipOakley
Copy link

If it (the suggestion in the lined reference) is working correctly, and is tested (hopefully you have checked), why not create a PR, with crisp commit message, or even submit a patch to the upstream Git list git@vger.kernel.org.

It's unlikely that a revert back to that version (2.18) is likely to happen, so let's move it forward with a Pull Request.

@PhilipOakley
Copy link

Hi @maxisam Thanks for clarifying. Unfortunately, in the wider domain, most things can be misinterpreted, so it's always worth over-clarifying points about what a comment is about, and what it's not about - I've often fallen into the trap of assuming people would make the same assumptions as me.

That said, if you can send a patch to upstream that would be even more useful 😉

@dscho
Copy link
Member

dscho commented Jun 21, 2019

@maxisam what might also help is a proper report including a working MCVE, i.e. a way to reproduce the issue. You chose to delete most of the bug reporting template, which is why you probably missed that part.

Without such a way to reproduce the issue, it is a lot less likely that anybody can help you.

@dscho
Copy link
Member

dscho commented Jun 21, 2019

The result is like this

https://public-inbox.org/git/20190101131947.GA18907@ash/

By the way, this is a poor bug report for multiple reasons:

  1. It does not at all state the problem.
  2. It sends the reader to a different web page, putting the entire burden of figuring out the bug report on others. You already put the burden of the bug fix on others, so that's a double-burden right there.
  3. Your link points to a patch, not to a bug report.
  4. That mail you linked to has one reply, claiming that the patch does not fix the problem.

If you want me to be as sloppy with a bug fix as you were reporting the bug, you might not be too happy about the obvious result.

@maxisam maxisam closed this as completed Jun 21, 2019
@PhilipOakley
Copy link

@maxisam We don't know what the problem is as you experience it. No one has actually 'nailed down' what the core problem is, hence it can't be fixed because we are still ignorant of what needs to be looked at or how to even set up the problem (as you experience it).

As seen on the much higher volume Git list, no one there had any more than an idea either (i.e. no one really followed up the one reply). This is Free, Collaborative, Open source, you get out what the contributors put in. Contributors only have a limited amount of time available, so it's a case of helping them to help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants