-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included curl doesn't support SCP/SFTP anymore since libssh2 not used in compilation. #2491
Comments
As I've tested :
I've oppened an issue at the curl team here : curl/curl#4848 |
As Git does not require this support, that is well within the range of the expected.
There are several things at play: which As this is not a Git-specific issue (and Git for Windows does not promise you to provide all the things you want, including fries), it might be an intentional change. Having said that, users who contribute their time and their effort are always welcome to ask for slightly more than users who don't. So maybe the Git for Windows project can accommodate what you want, it's just not yet clear how much effort/payload that requires. |
The Git Bash one is I discovered that problem using git-ftp for deploying a web app on a remote server using an SFTP link. I really think the issue was done by a change in the curl repository. But neither the binaries provides by the curl team nor the MSYS2 one seems impacted. I'm currently digging in repos to see how is retrieved and packaged the curl binary provided in Git for Windows and why it's not compiled with libssh2. |
|
It's an OSS projet ( https://github.com/git-ftp/git-ftp ). |
@fxmauricard since we ship Most likely, you'll just want to add Of course you will want to test this first by
Once that works, commit, open a PR, and I'll merge it, then rebuild the official package. |
Could you verify that the latest snapshot fixes the issue? |
I've tested the laster snapshot, and it works properly now! |
Excellent! |
Up to Git for Windows 2.16.1.2, the included curl binaries worked with scp/sftp protocols.
Since the Git for Windows 2.16.1.2 version, the support is broken.
I've investigated and it seems cURL was upgraded from 7.57 to 7.58.
By checking at commit in the cURL repository, it seems it could be the introduction of the libssh support for the scp/sftp backend that could change the compilation behavior for those who wanted to use libssh2.
See that commit : curl/curl@c92d2e1
As I'm not aware of how the Git for Windows package is made, I cannot check how the compilation flag for cURL are managed.
But we can find cURL binaries of the web that continue to use libssh2 after the 7.57 version.
The text was updated successfully, but these errors were encountered: