Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer: Suggest VSCodium #2537

Closed
GitMensch opened this issue Mar 6, 2020 · 1 comment · Fixed by git-for-windows/build-extra#278
Closed

Installer: Suggest VSCodium #2537

GitMensch opened this issue Mar 6, 2020 · 1 comment · Fixed by git-for-windows/build-extra#278
Milestone

Comments

@GitMensch
Copy link

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

Installer Git-2.25.1-64

Issue

Installer suggests to install and use VSCode User.
As those installed binaries are explicit non-free and also include telemetry (which can be seen as a security issue) I'd like to see the entry either being replaced or put next to a VSCodium option.

@dscho
Copy link
Member

dscho commented Mar 6, 2020

As those installed binaries are explicit non-free and also include telemetry (which can be seen as a security issue) I'd like to see the entry either being replaced or put next to a VSCodium option.

If you really feel strongly about this, you will find no obstacle to imitating, say, how Atom is supported, by copy-editing all the Atom-related parts of https://github.com/git-for-windows/build-extra/blob/master/installer/install.iss.

You can then test it by following the instructions at https://github.com/git-for-windows/git/wiki/Making-an-installer, and eventually open a Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants