Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installer window truncates words on right side #4727

Closed
1 task done
gitname opened this issue Dec 3, 2023 · 5 comments
Closed
1 task done

Installer window truncates words on right side #4727

gitname opened this issue Dec 3, 2023 · 5 comments
Milestone
v2.44.0

Comments

@gitname
Copy link

gitname commented Dec 3, 2023

There's a typo (or a layout bug) in the installer (highlight added by me).

image

I expected it to say "and" instead of "an".

Side note: I recommend switching to active voice instead of passive voice; i.e. from "it is recommended to" to "we recommend that you". That'll give readers more information about who is doing the recommending.

  • I was not able to find an open or closed issue matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

https://github.com/git-for-windows/git/releases/download/v2.43.0.windows.1/Git-2.43.0-64-bit.exe

  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
$ cmd.exe /c ver

Microsoft Windows [Version 10.0.22621.2715]
  • What options did you set as part of the installation? Or did you choose the
    defaults?
(I haven't completed the installation yet.)
  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

No
@gitname
Copy link
Author

gitname commented Dec 3, 2023

One of the subsequent steps also contains a similar "typo" (shown below; with highlighting added by me). I expected it to say "the" instead of "th".

image

Given this additional occurrence, I think the underlying issue is a layout bug as opposed to a typo.

@gitname gitname changed the title Installer window contains typo (on "Choosing the default editor used by Git" step) Installer window truncates words on right side Dec 3, 2023
@gitname
Copy link
Author

gitname commented Dec 3, 2023

Another subsequent step has occurrences. I am confident it's a layout bug as opposed to a typo, since this one has "partial characters."

image

dscho added a commit to dscho/build-extra that referenced this issue Dec 7, 2023
@dscho
installer: avoid cut-off text
72ff42d 
As reported in git-for-windows/git#4727, with
Windows' switch of the default system font a couple labels are now cut
off. Let's fix this by re-wrapping the text accordingly.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho mentioned this issue Dec 7, 2023
Merged
dscho added a commit to dscho/build-extra that referenced this issue Dec 8, 2023
@dscho
installer: avoid cut-off text
053916a 
As reported in git-for-windows/git#4727,
currently the installer shows labels that are cut off. It is a bit
unclear what caused this: While I first suspected the new Windows font,
Aptos, to be the culprit, that hypothesis was rejected when another
contributor reported that the text appears not to be cut off for them
(git-for-windows#536 (comment)).

Let's address this by re-wrapping the text more conservatively, so that
the text appears intact in more setups.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member

dscho commented Dec 13, 2023

Fixed via git-for-windows/build-extra#536

@dscho dscho closed this as completed Dec 13, 2023
@dscho dscho added this to the Next release milestone Dec 13, 2023
@dscho
Copy link
Member

dscho commented Dec 13, 2023

/mention relnote bug The Git for Windows installer showed cut-off text in some setups. This has been fixed.

@dscho
Copy link
Member

dscho commented Dec 13, 2023 •
edited by gitforwindowshelper bot
Loading

/add relnote bug The Git for Windows installer showed cut-off text in some setups. This has been fixed.

The workflow run was started

github-actions bot pushed a commit to git-for-windows/build-extra that referenced this issue Dec 13, 2023
Add a release note (bug)
02d5d27 
The Git for Windows installer [showed cut-off text in some
setups](git-for-windows/git#4727). This [has
been fixed](#536).

Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.44.0
Development

No branches or pull requests
2 participants
@dscho @gitname