Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New msys2-runtime version] Cygwin: revert use of CancelSyncronousIo on wait_thread. #5271

Closed
github-actions bot opened this issue Nov 23, 2024 · 1 comment
Closed

[New msys2-runtime version] Cygwin: revert use of CancelSyncronousIo on wait_thread. #5271

github-actions bot opened this issue Nov 23, 2024 · 1 comment
Labels
component-update
Milestone
v2.47.1

Comments

@github-actions
Copy link 

Cygwin: revert use of CancelSyncronousIo on wait_thread.

It appears this is causing hangs on native x86_64 in similar scenarios
as the hangs on ARM64, because `CancelSynchronousIo` is returning `TRUE`
but not canceling the `ReadFile` call as expected.

Addresses: https://github.com/msys2/MSYS2-packages/issues/4340#issuecomment-2491401847
Fixes: b091b47b9e56 ("cygthread: suspend thread before terminating.")
Signed-off-by: Jeremy Drake <cygwin@jdrake.com>

msys2/msys2-runtime@2eb6be1
@dscho
Copy link
Member

dscho commented Nov 25, 2024

Backported via git-for-windows/msys2-runtime#77

@dscho dscho closed this as completed Nov 25, 2024
@dscho dscho mentioned this issue Nov 25, 2024
Closed
@dscho dscho added this to the Next release milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component-update
Projects
None yet
Milestone
v2.47.1
Development

No branches or pull requests
1 participant
@dscho