New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carry non-locking status value in the environment. #1004

Merged

dscho merged 1 commit into git-for-windows:master from whoisj:nolock-env

Dec 20, 2016

whoisj commented Dec 19, 2016

If the user has specified '--no-lock-index' when calling git-status, it only seems reasonable that the user intends that option to be carried through to any child forks/procs as well. Currently, the '--no-lock-status' call is lost when submodules are checked. This change places the desired option into the environment, which is in turn passed down to all subsequent children.

With cmd_status checking for '--no-lock--status' first from args then from environment, we're able to keep the option set in all children.

Member

dscho commented Dec 20, 2016

Very good! Could you please sign off the patch and force-push an update?


          Carry non-locking status value in the environment.

45bad66

If the user has specified '--no-lock-index' when calling git-status, it only seems reasonable that the user intends that option to be carried through to any child forks/procs as well. Currently, the '--no-lock-status' call is lost when submodules are checked. This change places the desired option into the environment, which is in turn passed down to all subsequent children.

With cmd_status checking for '--no-lock--status' first from args then from environment, we're able to keep the option set in all children.

Signed-off-by: J Wyman <jeremy.wyman@microsoft.com>

dscho added a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

8b018c7

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho merged commit 2cd8ccb into git-for-windows:master

Member

dscho commented Dec 20, 2016

Thank you!

dscho added this to the v2.11.1 milestone

dscho added a commit to git-for-windows/build-extra that referenced this pull request


          Mention Bug Fix in release notes

The `--no-lock-index` option of `git status` [is now also respected
also in submodules](git-for-windows/git#1004).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho added a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

c3985bb

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

c6d64f0

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

f9f4bd8

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

dd3cd61

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

5d82e17

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

59f68c9

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

6791c63

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

614d955

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

ae044a8

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

6796c1e

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

a47f9f1

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

e1ccb0d

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

9de8176

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

0bdbcd8

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

6579e8e

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

98108e0

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

8aa35fa

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge 'gettickcount64' into HEAD

d4cb3a9

These two patches are really a fixup to PR #1004.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

9176d87

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

4ab6455

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

f33db80

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

3f29676

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

c400342

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

b13bc05

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

a5cfc0d

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

56ebb5c

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

809bbdc

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

7ce2b72

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

9ebd33e

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

317703e

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

13eb04b

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

55a20b6

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

96dea00

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

05a297a

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

c70ddbe

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

806e26d

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

fee2e64

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

63a3d5d

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

5d59ab4

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

5ae64d5

Carry non-locking status value in the environment.

git-for-windows-ci pushed a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

d2470c7

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

6eb3853

Carry non-locking status value in the environment.

dscho added a commit that referenced this pull request


          Merge pull request #1004 from whoisj/nolock-env

0210c6d

Carry non-locking status value in the environment.

This comment has been minimized.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet