fetch-pack: specify OBJECT_INFO_QUICK to remove duplicate prepare_pac… #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for early pickup of this to speedup git fetch on windows. |
When I run git fetch, git tries to find object for each local and remote refs. Without specifying OBJECT_INFO_QUICK, has_object_file list up entries in pack directory for each calls. This patch makes git fetch fast for the repositories having large number of refs, especially for windows because it's directory list up api is much slower than linux. Note: this patch was developed independently also by Jeff King: https://public-inbox.org/git/20171120202920.7ppcwmzkxifywtoj@sigill.intra.peff.net/ Signed-off-by: Takuto Ikuta <tikuta@chromium.org> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
object_info_quick
branch
from
dcd6c3c to
ff4a783
Compare
|
Thank you! I adjusted the formatting according to core Git's standards (they are pretty anal about their coding style, even if there is no fixed set of concrete rules, leaving a lot of room to discussions e.g. where to wrap the lines), and I also mentioned @peff's patch in the commit message. |
dscho
pushed a commit
to atetubou/git
that referenced
this pull request
Nov 28, 2017
This reverts commit 09ccec4. Using fscache here is not right way. It is better to specify OBJECT_INFO_QUICK flag for has_object_file instead, as was done in Pull Request git-for-windows#1379. This flag prevents directory list up for each refs also. Signed-off-by: Takuto Ikuta <tikuta@chromium.org> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Nov 29, 2017
fetch-pack: specify OBJECT_INFO_QUICK to remove duplicate prepare_pac…
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 6, 2017
fetch-pack: specify OBJECT_INFO_QUICK to remove duplicate prepare_pac…
dscho
added a commit
that referenced
this pull request
Jan 2, 2018
fetch-pack: specify OBJECT_INFO_QUICK to remove duplicate prepare_pac…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ked_git call
When I run git fetch, git tries to find object for each local and remote refs.
Without specifying OBJECT_INFO_QUICK, has_object_file list up entries in pack directory for each calls.
This patch makes git fetch fast for the repositories having large number of refs,
especially for windows because it's directory list up api is much slower than linux.
Signed-off-by: Takuto Ikuta tikuta@chromium.org