fscache: use FindFirstFileExW to avoid retrieving the short name #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use FindFirstFileExW with FindExInfoBasic to avoid forcing NTFS to look up the short name. Also switch to a larger (64K vs 4K) buffer using FIND_FIRST_EX_LARGE_FETCH to minimize round trips to the kernel. In a repo with ~200K files, this drops warm cache status times from 3.19 seconds to 2.67 seconds for a 16% savings. Signed-off-by: Ben Peart <benpeart@microsoft.com>
|
Excellent, thank you so much! |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Nov 5, 2018
The FSCache feature [now uses a faster method to enumerate files](git-for-windows/git#1908), making e.g. `git status` faster in large repositories. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 19, 2018
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 20, 2018
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Nov 21, 2018
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 23, 2018
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 30, 2018
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 1, 2018
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 9, 2018
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
to dscho/git
that referenced
this pull request
Dec 15, 2018
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 7, 2019
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
to dscho/git
that referenced
this pull request
Feb 7, 2019
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Oct 11, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Oct 20, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Oct 20, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Oct 21, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 21, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 21, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Oct 23, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 25, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 25, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 25, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 30, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 1, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 25, 2024
…-gfw fscache: use FindFirstFileExW to avoid retrieving the short name
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
fscache: use FindFirstFileExW to avoid retrieving the short name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FindFirstFileExW with FindExInfoBasic to avoid forcing NTFS to look up
the short name. Also switch to a larger (64K vs 4K) buffer using
FIND_FIRST_EX_LARGE_FETCH to minimize round trips to the kernel.
In a repo with ~200K files, this drops warm cache status times from 3.19
seconds to 2.67 seconds for a 16% savings.
Signed-off-by: Ben Peart benpeart@microsoft.com