Fix refresh error in gitk #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch that tried to escape the paths when refreshing was missing a continuation. This led to the error message Error executing git log: wrong # args: should be "escape_filter_paths paths" This fixes git-for-windows#2390 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
1 task
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Nov 5, 2019
A bug [was fixed](git-for-windows/git#2391) that prevented `gitk` from refreshing after new changes were committed. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2297 tried to escape the paths when refreshing, but it was missing a continuation. This led to the error message
This fixes #2390